nagachika 2e728d51e7 merge revision(s) 60123,60172,60189,60208,60210,60211: [Backport #14005] ... webrick: avoid unnecessary IO#sync= call Sockets and pipes are always created with FMODE_SYNC flag already set (otherwise many things would be broken). * lib/webrick/server.rb (accept_client): remove unnecessary IO#sync= call webrick: do not hang acceptor on slow TLS connections OpenSSL::SSL::SSLSocket#accept may block indefinitely on clients which negotiate the TCP connection, but fail (or are slow) to negotiate the subsequent TLS handshake. This prevents the multi-threaded WEBrick server from accepting other connections. Since the TLS handshake (via OpenSSL::SSL::SSLSocket#accept) consists of normal read/write traffic over TCP, handle it in the per-client thread, instead. Furthermore, using non-blocking accept() is useful for non-TLS sockets anyways because spurious wakeups are possible from select(2). * lib/webrick/server.rb (accept_client): use TCPServer#accept_nonblock and remove OpenSSL::SSL::SSLSocket#accept call * lib/webrick/server.rb (start_thread): call OpenSSL::SSL::SSLSocket#accept * test/webrick/test_ssl_server.rb (test_slow_connect): new test [ruby-core:83221] [Bug #14005] webrick: fix up r60172 By making the socket non-blocking in r60172, TLS/SSL negotiation via the SSL_accept function must handle non-blocking sockets properly and retry on SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE. OpenSSL::SSL::SSLSocket#accept cannot do that properly with a non-blocking socket, so it must use non-blocking logic of OpenSSL::SSL::SSLSocket#accept_nonblock. Thanks to MSP-Greg (Greg L) for finding this. * lib/webrick/server.rb (start_thread): use SSL_accept properly with non-blocking socket. [Bug #14013] [Bug #14005] webrick: fix up r60172 and revert r60189 Thanks to MSP-Greg (Greg L) for helping with this. * lib/webrick/server.rb (start_thread): ignore ECONNRESET, ECONNABORTED, EPROTO, and EINVAL on TLS negotiation errors the same way they were ignored before r60172 in the accept_client method of the main acceptor thread. [Bug #14013] [Bug #14005] webrick: fix up r60172 and r60208 Thanks to MSP-Greg (Greg L) for helping with this. * lib/webrick/server.rb (start_thread): fix non-local return introduced in r60208 webrick: fix up r60172 and r60210 Thanks to MSP-Greg (Greg L) for helping with this. * lib/webrick/server.rb (start_thread): properly fix non-local return introduced in r60208 and r60210 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e		2017-12-14 13:31:41 +00:00
..
httpauth	lib/*: remove closed checks	2016-11-21 23:05:41 +00:00
httpservlet	webrick: filter out HTTP_PROXY for CGIHandler	2016-07-22 16:43:12 +00:00
accesslog.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
cgi.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
compat.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
config.rb	Delay Utils.getservername until needed.	2016-12-07 12:59:48 +00:00
cookie.rb	* lib/cgi/cookie.rb (parse): don't allow , as a separator. [Bug #12791]	2016-09-27 03:17:47 +00:00
htmlutils.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
httpauth.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
httpproxy.rb	stdlib: avoid extra calls to eliminate "\n" from Base64	2016-01-10 00:35:43 +00:00
httprequest.rb	Multiple values X-Forwarded-Proto in webrick	2016-06-21 10:32:26 +00:00
httpresponse.rb	* lib/webrick/httpresponse.rb: Move error_body to method. It allow to	2016-03-29 03:45:32 +00:00
https.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
httpserver.rb	merge revision(s) 61197: [Backport #14184]	2017-12-14 13:14:12 +00:00
httpservlet.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
httpstatus.rb	merge revision(s) 59897:	2017-09-14 11:24:10 +00:00
httputils.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
httpversion.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00
log.rb	merge revision(s) 59897:	2017-09-14 11:24:10 +00:00
server.rb	merge revision(s) 60123,60172,60189,60208,60210,60211: [Backport #14005]	2017-12-14 13:31:41 +00:00
ssl.rb	* lib/webrick/ssl.rb: Accept string value for SSLCertName. It is used	2016-05-07 13:37:18 +00:00
utils.rb	webrick: use monotonic clock for timeouts	2016-10-14 01:48:52 +00:00
version.rb	Add frozen_string_literal: false for all files	2015-12-16 05:07:31 +00:00