mirror of
https://github.com/ruby/ruby.git
synced 2025-08-26 14:34:39 +02:00
71a8daecd9
This changes the CompactIndexClient to store etags received from the compact index in separate files rather than relying on the MD5 checksum of the file as the etag. Smoothes the upgrade from md5 etags to opaque by generating them when no etag file exists. This should reduce the initial impact of changing the caching behavior by reducing cache misses when the MD5 etag is the same. Eventually, the MD5 behavior should be retired and the etag should be considered completely opaque with no assumption that MD5 would match.
38 lines
1.2 KiB
Ruby
38 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "helpers/compact_index"
|
|
|
|
class CompactIndexPartialUpdate < CompactIndexAPI
|
|
# Stub the server to never return 304s. This simulates the behaviour of
|
|
# Fastly / Rubygems ignoring ETag headers.
|
|
def not_modified?(_checksum)
|
|
false
|
|
end
|
|
|
|
get "/versions" do
|
|
cached_versions_path = File.join(
|
|
Bundler.rubygems.user_home, ".bundle", "cache", "compact_index",
|
|
"localgemserver.test.80.dd34752a738ee965a2a4298dc16db6c5", "versions"
|
|
)
|
|
|
|
# Verify a cached copy of the versions file exists
|
|
unless File.binread(cached_versions_path).start_with?("created_at: ")
|
|
raise("Cached versions file should be present and have content")
|
|
end
|
|
|
|
# Verify that a partial request is made, starting from the index of the
|
|
# final byte of the cached file.
|
|
unless env["HTTP_RANGE"] == "bytes=#{File.binread(cached_versions_path).bytesize - 1}-"
|
|
raise("Range header should be present, and start from the index of the final byte of the cache. #{env["HTTP_RANGE"].inspect}")
|
|
end
|
|
|
|
etag_response do
|
|
# Return the exact contents of the cache.
|
|
File.binread(cached_versions_path)
|
|
end
|
|
end
|
|
end
|
|
|
|
require_relative "helpers/artifice"
|
|
|
|
Artifice.activate_with(CompactIndexPartialUpdate)
|