mirror of
https://github.com/ruby/ruby.git
synced 2025-09-15 16:44:01 +02:00
ce6863a0cf
Avoid reading unused lvars in Primitive.cexpr Previously on builds with optimizations disabled, this could result in an out of bounds read. When we had all of: * built with -O0 * Leaf builtin * Primitive.mandatory_only * "no args builtin", called by vm_call_single_noarg_inline_builti * The stack is escaped to the heap via binding or a proc This is because mk_builtin_loader generated reads for all locals regardless of whether they were used and in the case we generated a mandatory_only iseq that would include more variables than were actually available. On optimized builds, the invalid accesses would be optimized away, and this also was often unnoticed as the invalid access would just hit another part of the stack unless it had been escaped to the heap. The fix here is imperfect, as this could have false positives, but since Primitive.cexpr! is only available within the cruby codebase itself that's probably fine as a proper fix would be much more challenging (the only false positives we found were in rjit.rb). Fixes [Bug #20178] Co-authored-by: Adam Hess <HParker@github.com> --- bootstraptest/test_method.rb | 9 +++++++++ tool/mk_builtin_loader.rb | 6 ++++++ 2 files changed, 15 insertions(+) |
||
|---|---|---|
| .. | ||
| annocheck | ||
| bundler | ||
| lib | ||
| lrama | ||
| m4 | ||
| releng | ||
| rjit | ||
| ruby_vm | ||
| test | ||
| test_for_warn_bundled_gems | ||
| asm_parse.rb | ||
| bisect.sh | ||
| build-transcode | ||
| checksum.rb | ||
| colors | ||
| darwin-ar | ||
| darwin-cc | ||
| disable_ipv6.sh | ||
| downloader.rb | ||
| enc-case-folding.rb | ||
| enc-emoji-citrus-gen.rb | ||
| enc-emoji4unicode.rb | ||
| enc-unicode.rb | ||
| eval.rb | ||
| expand-config.rb | ||
| extlibs.rb | ||
| fake.rb | ||
| fetch-bundled_gems.rb | ||
| file2lastrev.rb | ||
| format-release | ||
| gen-github-release.rb | ||
| gen-mailmap.rb | ||
| gen_dummy_probes.rb | ||
| gen_ruby_tapset.rb | ||
| generic_erb.rb | ||
| git-refresh | ||
| gperf.sed | ||
| id2token.rb | ||
| ifchange | ||
| insns2vm.rb | ||
| install-sh | ||
| intern_ids.rb | ||
| leaked-globals | ||
| ln_sr.rb | ||
| make-snapshot | ||
| make_hgraph.rb | ||
| mdoc2man.rb | ||
| merger.rb | ||
| missing-baseruby.bat | ||
| mk_builtin_loader.rb | ||
| mkconfig.rb | ||
| mkrunnable.rb | ||
| node_name.rb | ||
| outdate-bundled-gems.rb | ||
| parse.rb | ||
| prereq.status | ||
| probes_to_wiki.rb | ||
| rbinstall.rb | ||
| rbs_skip_tests | ||
| rbuninstall.rb | ||
| redmine-backporter.rb | ||
| release.sh | ||
| rmdirs | ||
| rubyspec_temp.rb | ||
| run-gcov.rb | ||
| run-lcov.rb | ||
| runruby.rb | ||
| search-cgvars.rb | ||
| strip-rdoc.rb | ||
| sync_default_gems.rb | ||
| test-annocheck.sh | ||
| test-bundled-gems.rb | ||
| test-coverage.rb | ||
| transcode-tblgen.rb | ||
| travis_retry.sh | ||
| travis_wait.sh | ||
| update-bundled_gems.rb | ||
| update-deps | ||
| update-NEWS-gemlist.rb | ||
| update-NEWS-refs.rb | ||
| vtlh.rb | ||
| wasm-clangw | ||