mirror of
https://github.com/ruby/ruby.git
synced 2025-08-15 21:49:06 +02:00
51d0e58772
Because get_push_scope is a method call, Ruby will allocate an array
for *args even though it is not necessary to do so. Using a local
variable avoids the allocation.
Found by the performance warning in Ruby feature 21274.
0473c0cf32
135 lines
3.2 KiB
Ruby
135 lines
3.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "../command"
|
|
require_relative "../local_remote_options"
|
|
require_relative "../gemcutter_utilities"
|
|
require_relative "../package"
|
|
|
|
class Gem::Commands::PushCommand < Gem::Command
|
|
include Gem::LocalRemoteOptions
|
|
include Gem::GemcutterUtilities
|
|
|
|
def description # :nodoc:
|
|
<<-EOF
|
|
The push command uploads a gem to the push server (the default is
|
|
https://rubygems.org) and adds it to the index.
|
|
|
|
The gem can be removed from the index and deleted from the server using the yank
|
|
command. For further discussion see the help for the yank command.
|
|
|
|
The push command will use ~/.gem/credentials to authenticate to a server, but you can use the RubyGems environment variable GEM_HOST_API_KEY to set the api key to authenticate.
|
|
EOF
|
|
end
|
|
|
|
def arguments # :nodoc:
|
|
"GEM built gem to push up"
|
|
end
|
|
|
|
def usage # :nodoc:
|
|
"#{program_name} GEM"
|
|
end
|
|
|
|
def initialize
|
|
super "push", "Push a gem up to the gem server", host: host, attestations: []
|
|
|
|
@user_defined_host = false
|
|
|
|
add_proxy_option
|
|
add_key_option
|
|
add_otp_option
|
|
|
|
add_option("--host HOST",
|
|
"Push to another gemcutter-compatible host",
|
|
" (e.g. https://rubygems.org)") do |value, options|
|
|
options[:host] = value
|
|
@user_defined_host = true
|
|
end
|
|
|
|
add_option("--attestation FILE",
|
|
"Push with sigstore attestations") do |value, options|
|
|
options[:attestations] << value
|
|
end
|
|
|
|
@host = nil
|
|
end
|
|
|
|
def execute
|
|
gem_name = get_one_gem_name
|
|
default_gem_server, push_host = get_hosts_for(gem_name)
|
|
|
|
@host = if @user_defined_host
|
|
options[:host]
|
|
elsif default_gem_server
|
|
default_gem_server
|
|
elsif push_host
|
|
push_host
|
|
else
|
|
options[:host]
|
|
end
|
|
|
|
sign_in @host, scope: get_push_scope
|
|
|
|
send_gem(gem_name)
|
|
end
|
|
|
|
def send_gem(name)
|
|
args = [:post, "api/v1/gems"]
|
|
|
|
_, push_host = get_hosts_for(name)
|
|
|
|
@host ||= push_host
|
|
|
|
# Always include @host, even if it's nil
|
|
args += [@host, push_host]
|
|
|
|
say "Pushing gem to #{@host || Gem.host}..."
|
|
|
|
response = send_push_request(name, args)
|
|
|
|
with_response response
|
|
end
|
|
|
|
private
|
|
|
|
def send_push_request(name, args)
|
|
scope = get_push_scope
|
|
rubygems_api_request(*args, scope: scope) do |request|
|
|
body = Gem.read_binary name
|
|
if options[:attestations].any?
|
|
request.set_form([
|
|
["gem", body, { filename: name, content_type: "application/octet-stream" }],
|
|
get_attestations_part,
|
|
], "multipart/form-data")
|
|
else
|
|
request.body = body
|
|
request.add_field "Content-Type", "application/octet-stream"
|
|
request.add_field "Content-Length", request.body.size
|
|
end
|
|
request.add_field "Authorization", api_key
|
|
end
|
|
end
|
|
|
|
def get_hosts_for(name)
|
|
gem_metadata = Gem::Package.new(name).spec.metadata
|
|
|
|
[
|
|
gem_metadata["default_gem_server"],
|
|
gem_metadata["allowed_push_host"],
|
|
]
|
|
end
|
|
|
|
def get_push_scope
|
|
:push_rubygem
|
|
end
|
|
|
|
def get_attestations_part
|
|
bundles = "[" + options[:attestations].map do |attestation|
|
|
Gem.read_binary(attestation)
|
|
end.join(",") + "]"
|
|
[
|
|
"attestations",
|
|
bundles,
|
|
{ content_type: "application/json" },
|
|
]
|
|
end
|
|
end
|