electron/node-gyp
1
0
Fork 0
mirror of https://github.com/electron/node-gyp.git synced 2025-08-15 12:58:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

gyp: list(dict) so we can del dict(key) while iterating

Browse source 
Fixes #1998

Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: https://github.com/nodejs/node-gyp/pull/2009
This commit is contained in:
Christian Clauss 2019-12-31 21:39:18 +01:00 • committed by Rod Vagg
parent 26cd6eaea6
commit 14f2a07a39
No known key found for this signature in database
GPG key ID: C273792F7D83545D
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gyp/pylib/gyp/input.py
View file

@ -2286,7 +2286,7 @@ def SetUpConfigurations(target, target_dict):
merged_configurations[configuration])
# Now drop all the abstract ones.
for configuration in target_dict['configurations'].keys():
for configuration in list(target_dict['configurations']):
old_configuration_dict = target_dict['configurations'][configuration]
if old_configuration_dict.get('abstract'):
del target_dict['configurations'][configuration]