electron/node-gyp
1
0
Fork 0
mirror of https://github.com/electron/node-gyp.git synced 2025-08-15 12:58:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

deps: replace mkdirp with {recursive} mkdir

Browse source 
only supported on Node.js 10+

Closes: #2084
PR-URL: https://github.com/nodejs/node-gyp/pull/2123
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This commit is contained in:
Rod Vagg 2020-05-13 11:42:33 +10:00
parent a6b76a8b48
commit 4937722cf5
No known key found for this signature in database
GPG key ID: C273792F7D83545D
4 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/configure.js
View file

@ -4,7 +4,6 @@ const fs = require('graceful-fs')
const path = require('path')
const log = require('npmlog')
const os = require('os')
const mkdirp = require('mkdirp')
const processRelease = require('./process-release')
const win = process.platform === 'win32'
const findNodeDirectory = require('./find-node-directory')
@ -73,7 +72,7 @@ function configure (gyp, argv, callback) {
function createBuildDir () {
log.verbose('build dir', 'attempting to create "build" dir: %s', buildDir)
mkdirp(buildDir, function (err, isNew) {
fs.mkdir(buildDir, { recursive: true }, function (err, isNew) {
if (err) {
return callback(err)
}

5
lib/install.js
View file

@ -8,7 +8,6 @@ const crypto = require('crypto')
const log = require('npmlog')
const semver = require('semver')
const request = require('request')
const mkdir = require('mkdirp')
const processRelease = require('./process-release')
const win = process.platform === 'win32'
const getProxyFromURI = require('./proxy')
@ -114,7 +113,7 @@ function install (fs, gyp, argv, callback) {
log.verbose('ensuring nodedir is created', devDir)
// first create the dir for the node dev files
mkdir(devDir, function (err, created) {
fs.mkdir(devDir, { recursive: true }, function (err, created) {
if (err) {
if (err.code === 'EACCES') {
eaccesFallback(err)
@ -310,7 +309,7 @@ function install (fs, gyp, argv, callback) {
log.verbose(name, 'dir', dir)
log.verbose(name, 'url', libUrl)
mkdir(dir, function (err) {
fs.mkdir(dir, { recursive: true }, function (err) {
if (err) {
return done(err)
}

1
package.json
View file

@ -25,7 +25,6 @@
"env-paths": "^2.2.0",
"glob": "^7.1.4",
"graceful-fs": "^4.2.3",
"mkdirp": "^0.5.1",
"nopt": "^4.0.3",
"npmlog": "^4.1.2",
"request": "^2.88.2",

3
test/test-configure-python.js
View file

@ -10,7 +10,8 @@ const configure = requireInject('../lib/configure', {
openSync: function () { return 0 },
closeSync: function () { },
writeFile: function (file, data, cb) { cb() },
stat: function (file, cb) { cb(null, {}) }
stat: function (file, cb) { cb(null, {}) },
mkdir: function (dir, options, cb) { cb() }
}
})