electron/node-gyp
1
0
Fork 0
mirror of https://github.com/electron/node-gyp.git synced 2025-08-15 12:58:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

gyp: fix undefined name: cflags --> ldflags

Browse source 
The current code would raise NameError at runtime.

PR-URL: https://github.com/nodejs/node-gyp/pull/1901
Reviewed-By: Rod Vagg <rod@vagg.org>
This commit is contained in:
Christian Clauss 2019-10-01 07:54:49 +01:00 • committed by Rod Vagg
parent 2441932dc4
commit a84b885756
No known key found for this signature in database
GPG key ID: C273792F7D83545D
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gyp/pylib/gyp/xcode_emulation.py
View file

@ -846,7 +846,7 @@ class XcodeSettings(object):
if self._IsXCTest(): if self._IsXCTest():
platform_root = self._XcodePlatformPath(configname) platform_root = self._XcodePlatformPath(configname)
if platform_root: if platform_root:
cflags.append('-F' + platform_root + '/Developer/Library/Frameworks/') # noqa TODO @cclauss ldflags.append('-F' + platform_root + '/Developer/Library/Frameworks/')
is_extension = self._IsIosAppExtension() or self._IsIosWatchKitExtension() is_extension = self._IsIosAppExtension() or self._IsIosWatchKitExtension()
if sdk_root and is_extension: if sdk_root and is_extension: