electron/node-gyp
1
0
Fork 0
mirror of https://github.com/electron/node-gyp.git synced 2025-08-15 12:58:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Override BUILDING_UV_SHARED, BUILDING_V8_SHARED.

Browse source 
We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from
the common.gypi from the node.js source tree.  Override them with
USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with
`__declspec(dllimport)` instead of `__declspec(dllexport)`, which
is the desired attribute when building add-ons.

Fixes: https://github.com/nodejs/node-gyp/issues/914
PR-URL: https://github.com/nodejs/node-gyp/pull/915
Reviewed-By: Benjamin Byholm <bbyholm@abo.fi>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
This commit is contained in:
Ben Noordhuis 2016-04-28 10:36:05 +02:00
parent af35b2ad32
commit cc778e9215
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
addon.gypi
View file

@ -10,8 +10,14 @@
'<(node_root_dir)/deps/uv/include',
'<(node_root_dir)/deps/v8/include'
],
'defines!': [
'BUILDING_UV_SHARED=1', # Inherited from common.gypi.
'BUILDING_V8_SHARED=1', # Inherited from common.gypi.
],
'defines': [
'NODE_GYP_MODULE_NAME=>(_target_name)',
'USING_UV_SHARED=1',
'USING_V8_SHARED=1',
# Warn when using deprecated V8 APIs.
'V8_DEPRECATION_WARNINGS=1'
],