electron/node-gyp
1
0
Fork 0
mirror of https://github.com/electron/node-gyp.git synced 2025-08-15 12:58:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Only add "-undefined dynamic_lookup" to loadable_module targets

Browse source 
Adding "-undefined dynamic_lookup" to all targets makes it impossible to create Xcode projects with node-gyp for gyp files that also include "none" targets. Since non-targets don't have a framework phase, gyp errors when trying to add the link flag.

In addition, "-undefined dynamic_lookup" should be added as a linker flag, not a link library, so it's now passed in the "OTHER_LDFLAGS" setting
This commit is contained in:
Konstantin Käfer 2015-04-17 12:57:18 +02:00
parent fbe8c266f6
commit d41cb6356e
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
addon.gypi
View file

@ -14,6 +14,9 @@
['_type=="loadable_module"', { ['_type=="loadable_module"', {
'product_extension': 'node', 'product_extension': 'node',
'defines': [ 'BUILDING_NODE_EXTENSION' ], 'defines': [ 'BUILDING_NODE_EXTENSION' ],
'xcode_settings': {
'OTHER_LDFLAGS': [ '-undefined dynamic_lookup' ],
},
}], }],
['_type=="static_library"', { ['_type=="static_library"', {
@ -48,7 +51,6 @@
'conditions': [ 'conditions': [
[ 'OS=="mac"', { [ 'OS=="mac"', {
'defines': [ '_DARWIN_USE_64_BIT_INODE=1' ], 'defines': [ '_DARWIN_USE_64_BIT_INODE=1' ],
'libraries': [ '-undefined dynamic_lookup' ],
'xcode_settings': { 'xcode_settings': {
'DYLIB_INSTALL_NAME_BASE': '@rpath' 'DYLIB_INSTALL_NAME_BASE': '@rpath'
}, },