electron/node-gyp
1
0
Fork 0
mirror of https://github.com/electron/node-gyp.git synced 2025-08-15 12:58:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: convert internal classes from util.inherits to classes

Browse source 
BREAKING CHANGE: the `Gyp` class exported is now created using
ECMAScript classes and therefore might have small differences to classes
that were previously created with `util.inherits`.
This commit is contained in:
Luke Karrys 2023-10-27 16:40:36 -07:00
parent 355622f4aa
commit d52997e975
7 changed files with 307 additions and 344 deletions
Download patch file Download diff file Expand all files Collapse all files

59
test/test-find-python.js
View file

@ -4,43 +4,34 @@ delete process.env.PYTHON
const { describe, it } = require('mocha')
const assert = require('assert')
const { test: { PythonFinder, findPython: testFindPython } } = require('../lib/find-python')
const PythonFinder = require('../lib/find-python')
const { execFile } = require('../lib/util')
const { poison } = require('./common')
class TestPythonFinder extends PythonFinder {
constructor (...args) {
super(...args)
delete this.env.NODE_GYP_FORCE_PYTHON
}
async findPython () {
try {
return { err: null, python: await super.findPython() }
} catch (err) {
return { err, python: null }
}
}
}
describe('find-python', function () {
it('find python', async function () {
const found = await testFindPython(null)
const found = await PythonFinder.findPython(null)
const [err, stdout, stderr] = await execFile(found, ['-V'], { encoding: 'utf-8' })
assert.strictEqual(err, null)
assert.ok(/Python 3/.test(stdout))
assert.strictEqual(stderr, '')
})
function poison (object, property) {
function fail () {
console.error(Error(`Property ${property} should not have been accessed.`))
process.abort()
}
const descriptor = {
configurable: false,
enumerable: false,
get: fail,
set: fail
}
Object.defineProperty(object, property, descriptor)
}
function TestPythonFinder () { PythonFinder.apply(this, arguments) }
TestPythonFinder.prototype = Object.create(PythonFinder.prototype)
delete TestPythonFinder.prototype.env.NODE_GYP_FORCE_PYTHON
const findPython = async (f) => {
try {
return { err: null, python: await f.findPython() }
} catch (err) {
return { err, python: null }
}
}
it('find python - python', async function () {
const f = new TestPythonFinder('python')
f.execFile = async function (program, args, opts) {
@ -55,7 +46,7 @@ describe('find-python', function () {
return [null, '/path/python']
}
const { err, python } = await findPython(f)
const { err, python } = await f.findPython()
assert.strictEqual(err, null)
assert.strictEqual(python, '/path/python')
})
@ -72,7 +63,7 @@ describe('find-python', function () {
}
}
const { err } = await findPython(f)
const { err } = await f.findPython()
assert.ok(/Could not find any Python/.test(err))
assert.ok(/not supported/i.test(f.errorLog))
})
@ -89,7 +80,7 @@ describe('find-python', function () {
}
}
const { err } = await findPython(f)
const { err } = await f.findPython()
assert.ok(/Could not find any Python/.test(err))
assert.ok(/not in PATH/.test(f.errorLog))
})
@ -107,7 +98,7 @@ describe('find-python', function () {
}
}
const { err } = await findPython(f)
const { err } = await f.findPython()
assert.ok(/Could not find any Python/.test(err))
assert.ok(/not in PATH/.test(f.errorLog))
})
@ -136,7 +127,7 @@ describe('find-python', function () {
assert.fail()
}
}
const { err, python } = await findPython(f)
const { err, python } = await f.findPython()
assert.strictEqual(err, null)
assert.strictEqual(python, 'Z:\\snake.exe')
})
@ -159,7 +150,7 @@ describe('find-python', function () {
assert.fail()
}
}
const { err, python } = await findPython(f)
const { err, python } = await f.findPython()
assert.strictEqual(err, null)
assert.ok(python === expectedProgram)
})
@ -177,7 +168,7 @@ describe('find-python', function () {
assert.fail()
}
}
const { err } = await findPython(f)
const { err } = await f.findPython()
assert.ok(/Could not find any Python/.test(err))
assert.ok(/not in PATH/.test(f.errorLog))
})