mirror of
https://github.com/electron/node-gyp.git
synced 2025-08-15 12:58:19 +02:00
lib: migrate requests to fetch (#2220)
PR-URL: https://github.com/nodejs/node-gyp/pull/2220 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This commit is contained in:
Matias Lopez
GitHub
parent
a78b584236
commit
e81602ef55
5 changed files with 394 additions and 610 deletions
|
|
@ -1,8 +1,9 @@
|
|||
'use strict'
|
||||
|
||||
const test = require('tap').test
|
||||
const { test } = require('tap')
|
||||
const fs = require('fs')
|
||||
const path = require('path')
|
||||
const util = require('util')
|
||||
const http = require('http')
|
||||
const https = require('https')
|
||||
const install = require('../lib/install')
|
||||
|
|
@ -14,191 +15,142 @@ const log = require('npmlog')
|
|||
|
||||
log.level = 'warn'
|
||||
|
||||
test('download over http', function (t) {
|
||||
test('download over http', async (t) => {
|
||||
t.plan(2)
|
||||
|
||||
var server = http.createServer(function (req, res) {
|
||||
t.strictEqual(req.headers['user-agent'],
|
||||
'node-gyp v42 (node ' + process.version + ')')
|
||||
const server = http.createServer((req, res) => {
|
||||
t.strictEqual(req.headers['user-agent'], `node-gyp v42 (node ${process.version})`)
|
||||
res.end('ok')
|
||||
server.close()
|
||||
})
|
||||
|
||||
var host = 'localhost'
|
||||
server.listen(0, host, function () {
|
||||
var port = this.address().port
|
||||
var gyp = {
|
||||
opts: {},
|
||||
version: '42'
|
||||
}
|
||||
var url = 'http://' + host + ':' + port
|
||||
var req = install.test.download(gyp, {}, url)
|
||||
req.on('response', function (res) {
|
||||
var body = ''
|
||||
res.setEncoding('utf8')
|
||||
res.on('data', function (data) {
|
||||
body += data
|
||||
})
|
||||
res.on('end', function () {
|
||||
t.strictEqual(body, 'ok')
|
||||
})
|
||||
})
|
||||
})
|
||||
t.tearDown(() => new Promise((resolve) => server.close(resolve)))
|
||||
|
||||
const host = 'localhost'
|
||||
await new Promise((resolve) => server.listen(0, host, resolve))
|
||||
const { port } = server.address()
|
||||
const gyp = {
|
||||
opts: {},
|
||||
version: '42'
|
||||
}
|
||||
const url = `http://${host}:${port}`
|
||||
const res = await install.test.download(gyp, url)
|
||||
t.strictEqual(await res.text(), 'ok')
|
||||
})
|
||||
|
||||
test('download over https with custom ca', function (t) {
|
||||
test('download over https with custom ca', async (t) => {
|
||||
t.plan(3)
|
||||
|
||||
var cert = fs.readFileSync(path.join(__dirname, 'fixtures/server.crt'), 'utf8')
|
||||
var key = fs.readFileSync(path.join(__dirname, 'fixtures/server.key'), 'utf8')
|
||||
const cafile = path.join(__dirname, '/fixtures/ca.crt')
|
||||
const [cert, key, ca] = await Promise.all([
|
||||
fs.promises.readFile(path.join(__dirname, 'fixtures/server.crt'), 'utf8'),
|
||||
fs.promises.readFile(path.join(__dirname, 'fixtures/server.key'), 'utf8'),
|
||||
install.test.readCAFile(cafile)
|
||||
])
|
||||
|
||||
var cafile = path.join(__dirname, '/fixtures/ca.crt')
|
||||
var ca = install.test.readCAFile(cafile)
|
||||
t.strictEqual(ca.length, 1)
|
||||
|
||||
var options = { ca: ca, cert: cert, key: key }
|
||||
var server = https.createServer(options, function (req, res) {
|
||||
t.strictEqual(req.headers['user-agent'],
|
||||
'node-gyp v42 (node ' + process.version + ')')
|
||||
const options = { ca: ca, cert: cert, key: key }
|
||||
const server = https.createServer(options, (req, res) => {
|
||||
t.strictEqual(req.headers['user-agent'], `node-gyp v42 (node ${process.version})`)
|
||||
res.end('ok')
|
||||
server.close()
|
||||
})
|
||||
|
||||
server.on('clientError', function (err) {
|
||||
throw err
|
||||
})
|
||||
t.tearDown(() => new Promise((resolve) => server.close(resolve)))
|
||||
|
||||
var host = 'localhost'
|
||||
server.listen(8000, host, function () {
|
||||
var port = this.address().port
|
||||
var gyp = {
|
||||
opts: { cafile: cafile },
|
||||
version: '42'
|
||||
}
|
||||
var url = 'https://' + host + ':' + port
|
||||
var req = install.test.download(gyp, {}, url)
|
||||
req.on('response', function (res) {
|
||||
var body = ''
|
||||
res.setEncoding('utf8')
|
||||
res.on('data', function (data) {
|
||||
body += data
|
||||
})
|
||||
res.on('end', function () {
|
||||
t.strictEqual(body, 'ok')
|
||||
})
|
||||
})
|
||||
})
|
||||
server.on('clientError', (err) => { throw err })
|
||||
|
||||
const host = 'localhost'
|
||||
await new Promise((resolve) => server.listen(0, host, resolve))
|
||||
const { port } = server.address()
|
||||
const gyp = {
|
||||
opts: { cafile },
|
||||
version: '42'
|
||||
}
|
||||
const url = `https://${host}:${port}`
|
||||
const res = await install.test.download(gyp, url)
|
||||
t.strictEqual(await res.text(), 'ok')
|
||||
})
|
||||
|
||||
test('download over http with proxy', function (t) {
|
||||
test('download over http with proxy', async (t) => {
|
||||
t.plan(2)
|
||||
|
||||
var server = http.createServer(function (req, res) {
|
||||
t.strictEqual(req.headers['user-agent'],
|
||||
'node-gyp v42 (node ' + process.version + ')')
|
||||
const server = http.createServer((_, res) => {
|
||||
res.end('ok')
|
||||
pserver.close(function () {
|
||||
server.close()
|
||||
})
|
||||
})
|
||||
|
||||
var pserver = http.createServer(function (req, res) {
|
||||
t.strictEqual(req.headers['user-agent'],
|
||||
'node-gyp v42 (node ' + process.version + ')')
|
||||
const pserver = http.createServer((req, res) => {
|
||||
t.strictEqual(req.headers['user-agent'], `node-gyp v42 (node ${process.version})`)
|
||||
res.end('proxy ok')
|
||||
server.close(function () {
|
||||
pserver.close()
|
||||
})
|
||||
})
|
||||
|
||||
var host = 'localhost'
|
||||
server.listen(0, host, function () {
|
||||
var port = this.address().port
|
||||
pserver.listen(port + 1, host, function () {
|
||||
var gyp = {
|
||||
opts: {
|
||||
proxy: 'http://' + host + ':' + (port + 1)
|
||||
},
|
||||
version: '42'
|
||||
}
|
||||
var url = 'http://' + host + ':' + port
|
||||
var req = install.test.download(gyp, {}, url)
|
||||
req.on('response', function (res) {
|
||||
var body = ''
|
||||
res.setEncoding('utf8')
|
||||
res.on('data', function (data) {
|
||||
body += data
|
||||
})
|
||||
res.on('end', function () {
|
||||
t.strictEqual(body, 'proxy ok')
|
||||
})
|
||||
})
|
||||
})
|
||||
})
|
||||
t.tearDown(() => Promise.all([
|
||||
new Promise((resolve) => server.close(resolve)),
|
||||
new Promise((resolve) => pserver.close(resolve))
|
||||
]))
|
||||
|
||||
const host = 'localhost'
|
||||
await new Promise((resolve) => server.listen(0, host, resolve))
|
||||
const { port } = server.address()
|
||||
await new Promise((resolve) => pserver.listen(port + 1, host, resolve))
|
||||
const gyp = {
|
||||
opts: {
|
||||
proxy: `http://${host}:${port + 1}`,
|
||||
noproxy: 'bad'
|
||||
},
|
||||
version: '42'
|
||||
}
|
||||
const url = `http://${host}:${port}`
|
||||
const res = await install.test.download(gyp, url)
|
||||
t.strictEqual(await res.text(), 'proxy ok')
|
||||
})
|
||||
|
||||
test('download over http with noproxy', function (t) {
|
||||
test('download over http with noproxy', async (t) => {
|
||||
t.plan(2)
|
||||
|
||||
var server = http.createServer(function (req, res) {
|
||||
t.strictEqual(req.headers['user-agent'],
|
||||
'node-gyp v42 (node ' + process.version + ')')
|
||||
const server = http.createServer((req, res) => {
|
||||
t.strictEqual(req.headers['user-agent'], `node-gyp v42 (node ${process.version})`)
|
||||
res.end('ok')
|
||||
pserver.close(function () {
|
||||
server.close()
|
||||
})
|
||||
})
|
||||
|
||||
var pserver = http.createServer(function (req, res) {
|
||||
t.strictEqual(req.headers['user-agent'],
|
||||
'node-gyp v42 (node ' + process.version + ')')
|
||||
const pserver = http.createServer((_, res) => {
|
||||
res.end('proxy ok')
|
||||
server.close(function () {
|
||||
pserver.close()
|
||||
})
|
||||
})
|
||||
|
||||
var host = 'localhost'
|
||||
server.listen(0, host, function () {
|
||||
var port = this.address().port
|
||||
pserver.listen(port + 1, host, function () {
|
||||
var gyp = {
|
||||
opts: {
|
||||
proxy: 'http://' + host + ':' + (port + 1),
|
||||
noproxy: 'localhost'
|
||||
},
|
||||
version: '42'
|
||||
}
|
||||
var url = 'http://' + host + ':' + port
|
||||
var req = install.test.download(gyp, {}, url)
|
||||
req.on('response', function (res) {
|
||||
var body = ''
|
||||
res.setEncoding('utf8')
|
||||
res.on('data', function (data) {
|
||||
body += data
|
||||
})
|
||||
res.on('end', function () {
|
||||
t.strictEqual(body, 'ok')
|
||||
})
|
||||
})
|
||||
})
|
||||
})
|
||||
t.tearDown(() => Promise.all([
|
||||
new Promise((resolve) => server.close(resolve)),
|
||||
new Promise((resolve) => pserver.close(resolve))
|
||||
]))
|
||||
|
||||
const host = 'localhost'
|
||||
await new Promise((resolve) => server.listen(0, host, resolve))
|
||||
const { port } = server.address()
|
||||
await new Promise((resolve) => pserver.listen(port + 1, host, resolve))
|
||||
const gyp = {
|
||||
opts: {
|
||||
proxy: `http://${host}:${port + 1}`,
|
||||
noproxy: host
|
||||
},
|
||||
version: '42'
|
||||
}
|
||||
const url = `http://${host}:${port}`
|
||||
const res = await install.test.download(gyp, url)
|
||||
t.strictEqual(await res.text(), 'ok')
|
||||
})
|
||||
|
||||
test('download with missing cafile', function (t) {
|
||||
test('download with missing cafile', async (t) => {
|
||||
t.plan(1)
|
||||
var gyp = {
|
||||
const gyp = {
|
||||
opts: { cafile: 'no.such.file' }
|
||||
}
|
||||
try {
|
||||
install.test.download(gyp, {}, 'http://bad/')
|
||||
await install.test.download(gyp, {}, 'http://bad/')
|
||||
} catch (e) {
|
||||
t.ok(/no.such.file/.test(e.message))
|
||||
}
|
||||
})
|
||||
|
||||
test('check certificate splitting', function (t) {
|
||||
var cas = install.test.readCAFile(path.join(__dirname, 'fixtures/ca-bundle.crt'))
|
||||
test('check certificate splitting', async (t) => {
|
||||
const cas = await install.test.readCAFile(path.join(__dirname, 'fixtures/ca-bundle.crt'))
|
||||
t.plan(2)
|
||||
t.strictEqual(cas.length, 2)
|
||||
t.notStrictEqual(cas[0], cas[1])
|
||||
|
|
@ -206,7 +158,7 @@ test('check certificate splitting', function (t) {
|
|||
|
||||
// only run this test if we are running a version of Node with predictable version path behavior
|
||||
|
||||
test('download headers (actual)', function (t) {
|
||||
test('download headers (actual)', async (t) => {
|
||||
if (process.env.FAST_TEST ||
|
||||
process.release.name !== 'node' ||
|
||||
semver.prerelease(process.version) !== null ||
|
||||
|
|
@ -214,55 +166,42 @@ test('download headers (actual)', function (t) {
|
|||
return t.skip('Skipping actual download of headers due to test environment configuration')
|
||||
}
|
||||
|
||||
t.plan(17)
|
||||
t.plan(12)
|
||||
|
||||
const expectedDir = path.join(devDir, process.version.replace(/^v/, ''))
|
||||
rimraf(expectedDir, (err) => {
|
||||
t.ifError(err)
|
||||
await util.promisify(rimraf)(expectedDir)
|
||||
|
||||
const prog = gyp()
|
||||
prog.parseArgv([])
|
||||
prog.devDir = devDir
|
||||
log.level = 'warn'
|
||||
install(prog, [], (err) => {
|
||||
t.ifError(err)
|
||||
const prog = gyp()
|
||||
prog.parseArgv([])
|
||||
prog.devDir = devDir
|
||||
log.level = 'warn'
|
||||
await util.promisify(install)(prog, [])
|
||||
|
||||
fs.readFile(path.join(expectedDir, 'installVersion'), 'utf8', (err, data) => {
|
||||
t.ifError(err)
|
||||
t.strictEqual(data, '9\n', 'correct installVersion')
|
||||
})
|
||||
const data = await fs.promises.readFile(path.join(expectedDir, 'installVersion'), 'utf8')
|
||||
t.strictEqual(data, '9\n', 'correct installVersion')
|
||||
|
||||
fs.readdir(path.join(expectedDir, 'include/node'), (err, list) => {
|
||||
t.ifError(err)
|
||||
const list = await fs.promises.readdir(path.join(expectedDir, 'include/node'))
|
||||
t.ok(list.includes('common.gypi'))
|
||||
t.ok(list.includes('config.gypi'))
|
||||
t.ok(list.includes('node.h'))
|
||||
t.ok(list.includes('node_version.h'))
|
||||
t.ok(list.includes('openssl'))
|
||||
t.ok(list.includes('uv'))
|
||||
t.ok(list.includes('uv.h'))
|
||||
t.ok(list.includes('v8-platform.h'))
|
||||
t.ok(list.includes('v8.h'))
|
||||
t.ok(list.includes('zlib.h'))
|
||||
|
||||
t.ok(list.includes('common.gypi'))
|
||||
t.ok(list.includes('config.gypi'))
|
||||
t.ok(list.includes('node.h'))
|
||||
t.ok(list.includes('node_version.h'))
|
||||
t.ok(list.includes('openssl'))
|
||||
t.ok(list.includes('uv'))
|
||||
t.ok(list.includes('uv.h'))
|
||||
t.ok(list.includes('v8-platform.h'))
|
||||
t.ok(list.includes('v8.h'))
|
||||
t.ok(list.includes('zlib.h'))
|
||||
})
|
||||
const lines = (await fs.promises.readFile(path.join(expectedDir, 'include/node/node_version.h'), 'utf8')).split('\n')
|
||||
|
||||
fs.readFile(path.join(expectedDir, 'include/node/node_version.h'), 'utf8', (err, contents) => {
|
||||
t.ifError(err)
|
||||
// extract the 3 version parts from the defines to build a valid version string and
|
||||
// and check them against our current env version
|
||||
const version = ['major', 'minor', 'patch'].reduce((version, type) => {
|
||||
const re = new RegExp(`^#define\\sNODE_${type.toUpperCase()}_VERSION`)
|
||||
const line = lines.find((l) => re.test(l))
|
||||
const i = line ? parseInt(line.replace(/^[^0-9]+([0-9]+).*$/, '$1'), 10) : 'ERROR'
|
||||
return `${version}${type !== 'major' ? '.' : 'v'}${i}`
|
||||
}, '')
|
||||
|
||||
const lines = contents.split('\n')
|
||||
|
||||
// extract the 3 version parts from the defines to build a valid version string and
|
||||
// and check them against our current env version
|
||||
const version = ['major', 'minor', 'patch'].reduce((version, type) => {
|
||||
const re = new RegExp(`^#define\\sNODE_${type.toUpperCase()}_VERSION`)
|
||||
const line = lines.find((l) => re.test(l))
|
||||
const i = line ? parseInt(line.replace(/^[^0-9]+([0-9]+).*$/, '$1'), 10) : 'ERROR'
|
||||
return `${version}${type !== 'major' ? '.' : 'v'}${i}`
|
||||
}, '')
|
||||
|
||||
t.strictEqual(version, process.version)
|
||||
})
|
||||
})
|
||||
})
|
||||
t.strictEqual(version, process.version)
|
||||
})
|
||||
|
|
|
|||
|
|
@ -1,38 +1,46 @@
|
|||
'use strict'
|
||||
|
||||
const test = require('tap').test
|
||||
const install = require('../lib/install').test.install
|
||||
const { test } = require('tap')
|
||||
const { test: { install } } = require('../lib/install')
|
||||
const log = require('npmlog')
|
||||
|
||||
require('npmlog').level = 'error' // we expect a warning
|
||||
log.level = 'error' // we expect a warning
|
||||
|
||||
test('EACCES retry once', function (t) {
|
||||
test('EACCES retry once', async (t) => {
|
||||
t.plan(3)
|
||||
|
||||
var fs = {}
|
||||
fs.stat = function (path, cb) {
|
||||
var err = new Error()
|
||||
err.code = 'EACCES'
|
||||
cb(err)
|
||||
t.ok(true)
|
||||
const fs = {
|
||||
promises: {
|
||||
stat (_) {
|
||||
const err = new Error()
|
||||
err.code = 'EACCES'
|
||||
t.ok(true)
|
||||
throw err
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
var gyp = {}
|
||||
gyp.devDir = __dirname
|
||||
gyp.opts = {}
|
||||
gyp.opts.ensure = true
|
||||
gyp.commands = {}
|
||||
gyp.commands.install = function (argv, cb) {
|
||||
install(fs, gyp, argv, cb)
|
||||
}
|
||||
gyp.commands.remove = function (argv, cb) {
|
||||
cb()
|
||||
const Gyp = {
|
||||
devDir: __dirname,
|
||||
opts: {
|
||||
ensure: true
|
||||
},
|
||||
commands: {
|
||||
install (argv, cb) {
|
||||
install(fs, Gyp, argv).then(cb, cb)
|
||||
},
|
||||
remove (_, cb) {
|
||||
cb()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
gyp.commands.install([], function (err) {
|
||||
try {
|
||||
await install(fs, Gyp, [])
|
||||
} catch (err) {
|
||||
t.ok(true)
|
||||
if (/"pre" versions of node cannot be installed/.test(err.message)) {
|
||||
t.ok(true)
|
||||
t.ok(true)
|
||||
}
|
||||
})
|
||||
}
|
||||
})
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue