node-gyp

1356 commits 6 branches 0 tags 5 MiB

Author	SHA1	Message	Date
Andrew Casey	1f7e1e93b5	lib: ignore VS instances that cause COMExceptions I have quite a few instances of VS installed and it looks like Find-VisualStudio.cs enumerates all of them, even when find-visualstudio.js already knows which one it wants (from the environment variable in the developer command prompt). One of them (from 15.7.2, if that's interesting) causes a COMException on the ISetupInstance2.GetPackages call. Ignoring such packages seems harmless and unblocks the rest of the run. PR-URL: https://github.com/nodejs/node-gyp/pull/2018 Reviewed-By: João Reis <reis@janeasystems.com>	2020-01-14 15:59:29 +00:00
João Reis	7fe4095974	win: generic Visual Studio 2017 detection PR-URL: https://github.com/nodejs/node-gyp/pull/1762 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Refael Ackermann <refack@gmail.com>	2019-06-04 16:38:05 +01:00

Author

SHA1

Message

Date

Andrew Casey

1f7e1e93b5

lib: ignore VS instances that cause COMExceptions

I have quite a few instances of VS installed and it looks like
Find-VisualStudio.cs enumerates all of them, even when
find-visualstudio.js already knows which one it wants (from the
environment variable in the developer command prompt).  One of them
(from 15.7.2, if that's interesting) causes a COMException on the
ISetupInstance2.GetPackages call.  Ignoring such packages seems
harmless and unblocks the rest of the run.

PR-URL: https://github.com/nodejs/node-gyp/pull/2018
Reviewed-By: João Reis <reis@janeasystems.com>

2020-01-14 15:59:29 +00:00

João Reis

7fe4095974

win: generic Visual Studio 2017 detection

PR-URL: https://github.com/nodejs/node-gyp/pull/1762
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Refael Ackermann <refack@gmail.com>

2019-06-04 16:38:05 +01:00

Renamed from lib/Find-VS2017.cs (Browse further)

2 commits