Commit graph

14 commits

Author SHA1 Message Date
Felix Rieseberg
e25ec9e836 fix: Monkey-patch fs 2024-10-08 10:36:26 -04:00
Luke Karrys
355622f4aa feat: convert all internal functions to async/await
BREAKING CHANGE: All internal functions have been coverted to return
promises and no longer accept callbacks. This is not a breaking change
for users but may be breaking to consumers of `node-gyp` if you are
requiring internal functions directly.
2023-10-28 08:59:57 -07:00
Luke Karrys
192eec2aca
Sync deps and engines with npm (#2770)
* feat!: update `engines.node` to `^14.17.0 || ^16.13.0 || >=18.0.0`

* deps: nopt@^7.0.0

* feat: replace npmlog with proc-log

* deps: standard@17.0.0 and fix linting errors

* deps: which@3.0.0
- this also promiisifies the build command

* deps: glob@8.0.3

* feat: drop rimraf dependency

* fix: use fs/promises in favor of fs.promises
2023-06-20 15:44:18 +02:00
Rod Vagg
e40c99e283
src: implement standard.js linting
In addition:

* moved module.exports to the bottom
* no single-line if statements
* no if statements without a {
* const for requires
* array declarations get spaces inside [ ]
* 'use strict' in all .js files

PR-URL: https://github.com/nodejs/node-gyp/pull/1794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
2019-07-06 14:36:37 +10:00
Jon Moss
9e46872ea3
bin,lib: remove extra comments/lines/spaces
- Removes "module dependencies" comments and things that, IMHO, don't add
too much value. Happy to add back if helps some people when reading
through `node-gyp`.
- DRY up `lib/process-release.js`.
- Removes a bunch of extra blank lines, as well as random spaces.

PR-URL: https://github.com/nodejs/node-gyp/pull/1508
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-04-24 10:27:29 +10:00
Nathan Rajlich
47de81f963 initial take at using 'npmlog' for logging
* adds a '--loglevel' switch to node-gyp which accepts the same values as npm
 * now the '--verbose' flag is simply an alias to '--loglevel=verbose'
 * this simplifies the code a bit, since any logging logic is now removed
 * more log levels! it's mostly verbose() and info() being used
   * still need to go back and move some of logging calls to a better level
2012-06-06 18:01:08 -07:00
Nathan Rajlich
aae45396ec remove the hook stuff 2012-04-08 15:47:53 -07:00
Nathan Rajlich
9a4a58034f Update/simplify the 'clean' command to just remove the "build" directory.
Much simpler :)
2012-02-27 17:36:52 -08:00
Nathan Rajlich
bd693e502c Clean the 'gyp-sun-tool' file. 2012-02-25 18:37:19 -08:00
Nathan Rajlich
b2e8abcdc0 Hack in 'before' and 'after' hook events for the 'clean', 'configure', and 'build' commands.
Part of #9.
2012-02-12 15:58:09 -08:00
Nathan Rajlich
06aac83907 'clean': target.mk -> target.gyp.mk 2012-02-05 19:12:49 -08:00
Christopher Jeffrey
50f572bda5 Have node-gyp clean remove Makefile.gyp 2012-02-05 21:00:59 -06:00
Nathan Rajlich
9d23e05691 Clean the Debug and Release dirs on Windows. 2012-02-04 13:44:39 -08:00
Nathan Rajlich
a8f4f87df3 Implement the 'clean' command. 2012-02-04 13:18:19 -08:00