Commit graph

18 commits

Author SHA1 Message Date
Chengzhong Wu
d38af2e0c2
feat: allow VCINSTALLDIR to specify a portable instance (#3036) 2024-07-09 16:13:40 +01:00
Hüseyin Açacak
323957b74e
win: add an arch check to VS 2019 (#3025) 2024-04-23 15:46:11 +02:00
Christian Clauss
0bab6a071b
GitHub Actions: npm test is failing Windows tests on M1 Macs (#3011)
* GitHub Actions: npm test is failing Windows tests on M1 Macs

`npm test` is running and failing Windows `find-visualstudio` tests on an M1 Mac!!!

These tests are not being run or not failing on Intel Macs.

* Only run "Find Visual Studio" tests on Windows

* Update test/test-find-visualstudio.js

Co-authored-by: Christian Clauss <cclauss@me.com>

---------

Co-authored-by: Stefan Stojanovic <StefanStojanovic@users.noreply.github.com>
2024-04-11 17:34:49 +02:00
Stefan Stojanovic
391cc5b9b2
win: update supported vs versions (#2959)
Drop VS2017 support for Node.js v22 and above.

Refs: https://github.com/nodejs/build/pull/3603
Refs: https://github.com/nodejs/node/pull/45427
2024-03-06 17:32:44 +01:00
Jaroslav
109e3d4245
feat: improve visual studio detection (#2957)
Detect visual studio installation using the VSSetup module and
Get-VSSetupInstance method. It works even in systems with the
Constrained language mode of PowerShell.
2024-02-09 02:33:54 +01:00
Luke Karrys
d52997e975 feat: convert internal classes from util.inherits to classes
BREAKING CHANGE: the `Gyp` class exported is now created using
ECMAScript classes and therefore might have small differences to classes
that were previously created with `util.inherits`.
2023-10-28 09:29:04 -07:00
Luke Karrys
355622f4aa feat: convert all internal functions to async/await
BREAKING CHANGE: All internal functions have been coverted to return
promises and no longer accept callbacks. This is not a breaking change
for users but may be breaking to consumers of `node-gyp` if you are
requiring internal functions directly.
2023-10-28 08:59:57 -07:00
Luke Karrys
192eec2aca
Sync deps and engines with npm (#2770)
* feat!: update `engines.node` to `^14.17.0 || ^16.13.0 || >=18.0.0`

* deps: nopt@^7.0.0

* feat: replace npmlog with proc-log

* deps: standard@17.0.0 and fix linting errors

* deps: which@3.0.0
- this also promiisifies the build command

* deps: glob@8.0.3

* feat: drop rimraf dependency

* fix: use fs/promises in favor of fs.promises
2023-06-20 15:44:18 +02:00
Stefan Stojanovic
5df2b72a8f
Migration from tap to mocha (#2851)
* migrate from tap to mocha

After make-fetch-happen update GitHub Actions started failing. Migrating
from tap to mocha testing framework for GitHub Action stability.

* write custom test reporter for more verbose output

Implemented a simple custom mocha test reporter to replace the default
one. Made test report more developer friendly.
2023-06-05 17:05:29 +02:00
Dennis Ameling
bb76021d35 feat: add support for native windows arm64 build tools
Visual Studio 2022 17.4 adds a native C++ compiler for Windows on ARM.
This allows arm64 devices to leverage native build tools, leading to
a 35% (or more) speed increase.
https://devblogs.microsoft.com/visualstudio/arm64-visual-studio-is-officially-here/

Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
2023-05-25 12:29:04 +02:00
João Reis
968c9067d7
win: support VS 2017 Desktop Express
Fixes: https://github.com/nodejs/node-gyp/issues/1881
PR-URL: https://github.com/nodejs/node-gyp/pull/1902
Reviewed-By: Rod Vagg <rod@vagg.org>
2019-10-03 11:08:29 +10:00
João Reis
656117cc4a win: make VS path match case-insensitive
Fixes: https://github.com/nodejs/node-gyp/issues/1805
PR-URL: https://github.com/nodejs/node-gyp/pull/1806
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
2019-07-08 16:06:24 +01:00
Rod Vagg
e40c99e283
src: implement standard.js linting
In addition:

* moved module.exports to the bottom
* no single-line if statements
* no if statements without a {
* const for requires
* array declarations get spaces inside [ ]
* 'use strict' in all .js files

PR-URL: https://github.com/nodejs/node-gyp/pull/1794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
2019-07-06 14:36:37 +10:00
Rod Vagg
a52c6eb9e8
test: migrate from tape to tap
PR-URL: https://github.com/nodejs/node-gyp/pull/1795
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-06-25 11:26:08 +10:00
João Reis
0efb8fb34b win: support running in VS Command Prompt
PR-URL: https://github.com/nodejs/node-gyp/pull/1762
Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-06-04 16:40:01 +01:00
João Reis
360ddbdf3a win: add support for Visual Studio 2019
PR-URL: https://github.com/nodejs/node-gyp/pull/1762
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-06-04 16:39:54 +01:00
João Reis
8f43f68275 win: detect all VS versions in node-gyp
PR-URL: https://github.com/nodejs/node-gyp/pull/1762
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-06-04 16:39:49 +01:00
João Reis
7fe4095974 win: generic Visual Studio 2017 detection
PR-URL: https://github.com/nodejs/node-gyp/pull/1762
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-06-04 16:38:05 +01:00