Commit graph

8 commits

Author SHA1 Message Date
James Cook
53c99ae573
Fix reading msvs version on Windows (#2644)
* fix: fix reading msvs version on windows
2023-06-25 17:35:41 +02:00
Stefan Stojanovic
5df2b72a8f
Migration from tap to mocha (#2851)
* migrate from tap to mocha

After make-fetch-happen update GitHub Actions started failing. Migrating
from tap to mocha testing framework for GitHub Action stability.

* write custom test reporter for more verbose output

Implemented a simple custom mocha test reporter to replace the default
one. Made test report more developer friendly.
2023-06-05 17:05:29 +02:00
Cheng Zhao
eef4eefccb fix: _ in npm_config_ env variables 2022-02-16 10:48:47 +11:00
Shelley Vohr
2317dc400c
ci: switch to GitHub Actions
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Matias Lopez <imatlopez@gmail.com>
PR-URL: https://github.com/nodejs/node-gyp/pull/2210
Closes: #2127
Closes: #2209
2020-10-15 10:24:59 +11:00
Rod Vagg
e40c99e283
src: implement standard.js linting
In addition:

* moved module.exports to the bottom
* no single-line if statements
* no if statements without a {
* const for requires
* array declarations get spaces inside [ ]
* 'use strict' in all .js files

PR-URL: https://github.com/nodejs/node-gyp/pull/1794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
2019-07-06 14:36:37 +10:00
Rod Vagg
a52c6eb9e8
test: migrate from tape to tap
PR-URL: https://github.com/nodejs/node-gyp/pull/1795
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-06-25 11:26:08 +10:00
Ben Noordhuis
0e2dfda1f3 Fix test/test-options when run through npm test.
`npm test` dumps a ton of npm_config_* variables in the environment.
Remove those before starting the actual test.

PR-URL: https://github.com/nodejs/node-gyp/pull/755
Reviewed-By: Rod Vagg <rod@vagg.org>
2015-11-19 19:10:27 +01:00
Ben Noordhuis
2ac7de02c4 Fix infinite loop with zero-length options.
The bundled copy of GYP enters an infinite loop when it encounters a
zero-length option so ensure those don't get through.

The root cause is a bad guard in gyp/pylib/gyp/input.py that doesn't
take into account that `'' in 'whatever'` evaluates to True.

Upstream fix at https://codereview.chromium.org/1364373004/.

Fixes: https://github.com/nodejs/node-gyp/issues/744
PR-URL: https://github.com/nodejs/node-gyp/pull/745
Reviewed-By: Nathan Rajlich <nathan@tootallnate.net>
2015-09-25 21:40:49 +02:00