archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

test: skip wasm-allocation tests for pointer compression builds

Browse source 
V8 isolate group initialization forces allocation of the virtual
memory cage with pointer compression builds and simply would not
work when there is a smaller hard limit on the virtual memory.

PR-URL: https://github.com/nodejs/node/pull/58171
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Joyee Cheung 2025-05-04 21:38:34 +02:00 • committed by Node.js GitHub Bot
parent ac8706196b
commit 20c4b80ffc
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/wasm-allocation/wasm-allocation.status
View file

@ -6,5 +6,5 @@ prefix wasm-allocation
[true] # This section applies to all platforms [true] # This section applies to all platforms
[$system!=linux || $asan==on] [$system!=linux || $asan==on || $pointer_compression==on]
test-wasm-allocation: SKIP test-wasm-allocation: SKIP

4
tools/test.py
View file

@ -1628,6 +1628,9 @@ def get_asan_state(vm, context):
asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip() asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip()
return "on" if asan == "1" else "off" return "on" if asan == "1" else "off"
def get_pointer_compression_state(vm, context):
pointer_compression = Execute([vm, '-p', 'process.config.variables.v8_enable_pointer_compression'], context).stdout.strip()
return "on" if pointer_compression == "1" else "off"
def Main(): def Main():
parser = BuildOptions() parser = BuildOptions()
@ -1726,6 +1729,7 @@ def Main():
'arch': vmArch, 'arch': vmArch,
'type': get_env_type(vm, options.type, context), 'type': get_env_type(vm, options.type, context),
'asan': get_asan_state(vm, context), 'asan': get_asan_state(vm, context),
'pointer_compression': get_pointer_compression_state(vm, context),
} }
test_list = root.ListTests([], path, context, arch, mode) test_list = root.ListTests([], path, context, arch, mode)
unclassified_tests += test_list unclassified_tests += test_list