Commit graph

42234 commits

Author SHA1 Message Date
RafaelGSS
cdab368bc3
Working on v20.19.5
PR-URL: https://github.com/nodejs-private/node-private/pull/727
2025-07-15 19:03:40 -03:00
RafaelGSS
b08ee299b0
2025-07-15, Version 20.19.4 'Iron' (LTS)
This is a security release.

Notable changes:

lib:
  * (CVE-2025-27210) handle all windows reserved driver name

PR-URL: https://github.com/nodejs-private/node-private/pull/727
2025-07-11 15:38:05 -03:00
RafaelGSS
db7b93fcef
lib: handle all windows reserved driver name
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs-private/node-private/pull/721
Refs: https://hackerone.com/reports/3160912
CVE-ID: CVE-2025-27210
2025-07-11 15:37:10 -03:00
Marco Ippolito
23bc2d0e4f
Working on v20.19.4
PR-URL: https://github.com/nodejs/node/pull/58588
2025-06-23 10:31:10 +02:00
Marco Ippolito
76f82824bf
2025-06-23, Version 20.19.3 'Iron' (LTS)
Notable changes:

crypto:
  * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) https://github.com/nodejs/node/pull/56142
  * update root certificates to NSS 3.108 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/57381
deps:
  * update timezone to 2025b (Node.js GitHub Bot) https://github.com/nodejs/node/pull/57857
doc:
  * add dario-piotrowicz to collaborators (Dario Piotrowicz) https://github.com/nodejs/node/pull/58102

PR-URL: https://github.com/nodejs/node/pull/58588
2025-06-20 07:22:15 +02:00
Marco Ippolito
850192b06b
test: skip broken sea on rhel8
PR-URL: https://github.com/nodejs/node/pull/58761
Refs: https://github.com/nodejs/node/pull/58588
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2025-06-20 07:19:30 +02:00
Aviv Keller
b427ae4f34
meta: remove build-windows.yml
PR-URL: https://github.com/nodejs/node/pull/54662
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-11 09:21:25 +02:00
Node.js GitHub Bot
3cf7cfb695
test: update WPT for WebCryptoAPI to edd42c005c
PR-URL: https://github.com/nodejs/node/pull/57365
Backport-PR-URL: https://github.com/nodejs/node/pull/58589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-11 09:21:24 +02:00
Filip Skokan
f56e62851a
crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits
PR-URL: https://github.com/nodejs/node/pull/55866
Backport-PR-URL: https://github.com/nodejs/node/pull/58589
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2025-06-11 09:21:24 +02:00
Filip Skokan
8237346fb7
test,crypto: update WebCryptoAPI WPT
Refs: #54572
Refs: #54468
PR-URL: https://github.com/nodejs/node/pull/54593
Backport-PR-URL: https://github.com/nodejs/node/pull/58589
Refs: https://github.com/nodejs/node/issues/54572
Refs: https://github.com/nodejs/node/pull/54468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-11 09:21:24 +02:00
Michaël Zasso
d09008add3
deps: V8: cherry-pick 1a3ecc2483b2
Original commit message:

    Fix build issue, remove unneeded include uchar.h.

    Follow the conversation on:
    https://groups.google.com/g/v8-dev/c/nsbshwlmP3c.

    The `uchar.h` include is not necessary.
    It was added to get the definition of char16_t but that's an intrinsic
    type in C++.

    Change-Id: I0aaa11dba0be3ccad15b9e421f8bae71450d443b
    Reviewed-on: 4823404
    Reviewed-by: Omer Katz <omerkatz@chromium.org>
    Commit-Queue: Eric Leese <leese@chromium.org>
    Reviewed-by: Eric Leese <leese@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#89787}

Refs: 1a3ecc2483
PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/58342
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-11 09:21:24 +02:00
Andrey Kosyakov
fd56652425
deps: V8: cherry-pick 182d9c05e78b
Original commit message:

    Define UChar as char16_t

    We used to have UChar defined as uint16_t which does not go along
    with STL these days if you try to have an std::basic_string<> of it,
    as there are no standard std::char_traits<> specialization for uint16_t.

    This switches UChar to char16_t where practical, introducing a few
    compatibility shims to keep CL size small, as (1) this would likely
    have to be back-ported and (2) crdtp extensively uses uint16_t for
    wide chars.

    Bug: b:296390693
    Change-Id: I66a32d8f0050915225b187de56896c26dd76163d
    Reviewed-on: 4789966
    Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Auto-Submit: Andrey Kosyakov <caseq@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#89559}

Refs: 182d9c05e7
PR-URL: https://github.com/nodejs/node/pull/58342
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-11 09:21:23 +02:00
Hans Wennborg
447481e829
deps: V8: cherry-pick third_party/zlib@646b7f5697
Original commit message:

    [zlib][build] Remove fdopen #defines in zutil.h.

    The latest version of Clang changed what macros it predefines on Apple
    targets, causing errors about predefined macros in zlib.

    See:
    4bd9a71f35

    Bug: 1519899
    Change-Id: Ie75ef4078f2c86d89ba6c036ddd13e768a40ccbb
    Reviewed-on: 5237020
    Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
    Commit-Queue: Hans Wennborg <hans@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1253252}
    NOKEYCHECK=True
    GitOrigin-RevId: 2f39ac8d0a414dd65c0e1d5aae38c8f97aa06ae9

Refs: 646b7f5697
PR-URL: https://github.com/nodejs/node/pull/58342
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-11 09:21:23 +02:00
Chengzhong Wu
152112505a
typings: fix ImportModuleDynamicallyCallback return type
PR-URL: https://github.com/nodejs/node/pull/57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:23 +02:00
James M Snell
f57765bdcf
test: mark test-without-async-context-frame flaky on windows
Refs: https://github.com/nodejs/node/issues/56751
Refs: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32254/RUN_SUBSET=0,nodes=win2019-COMPILED_BY-vs2022/testReport/(root)/parallel/test_without_async_context_frame/
PR-URL: https://github.com/nodejs/node/pull/56753
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-06-11 09:21:23 +02:00
Rafael Gonzaga
e80669be0d
doc: mention reports should align with Node.js CoC
Refs: https://github.com/nodejs/moderation/issues/830
PR-URL: https://github.com/nodejs/node/pull/57607
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-06-11 09:21:22 +02:00
Gürgün Dayıoğlu
7b2c0bc92e
doc: add gurgunday as triager
PR-URL: https://github.com/nodejs/node/pull/57594
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2025-06-11 09:21:22 +02:00
Dario Piotrowicz
791e4879de
doc: document REPL custom eval arguments
PR-URL: https://github.com/nodejs/node/pull/57690
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:22 +02:00
Alessandro Miliucci
2917f09876
doc: improved fetch docs
PR-URL: https://github.com/nodejs/node/pull/57296
Refs: https://undici.nodejs.org
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:22 +02:00
Dario Piotrowicz
d940b15843
doc: clarify unhandledRejection events behaviors in process doc
PR-URL: https://github.com/nodejs/node/pull/57654
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:21 +02:00
Shima Ryuhei
cdf3fa241c
http2: skip writeHead if stream is closed
Fixes: https://github.com/nodejs/node/issues/57416
PR-URL: https://github.com/nodejs/node/pull/57686
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2025-06-11 09:21:21 +02:00
Michaël Zasso
d582954434
src: remove unused variable in crypto_x509.cc
PR-URL: https://github.com/nodejs/node/pull/57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-06-11 09:21:21 +02:00
Yukihiro Hasegawa
71c664fab7
doc: update position type to integer | null in fs
PR-URL: https://github.com/nodejs/node/pull/57745
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:20 +02:00
Antoine du Hamel
b90c4ab937
tools: remove unused osx-pkg-postinstall.sh
PR-URL: https://github.com/nodejs/node/pull/57667
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:20 +02:00
Elves Vieira
414013dcfb
tools: edit create-release-proposal workflow to handle pr body length
PR-URL: https://github.com/nodejs/node/pull/57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-06-11 09:21:20 +02:00
Node.js GitHub Bot
eb447168df
deps: update simdutf to 6.4.2
PR-URL: https://github.com/nodejs/node/pull/57855
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-11 09:21:20 +02:00
Kushagra Pandey
bbd5aec785
http2: fix graceful session close
Fix issue where session.close() prematurely destroys the session
when response.end() was called with an empty payload while active
http2 streams still existed. This change ensures that sessions are
closed gracefully only after all http2 streams complete and clients
properly receive the GOAWAY frame as per the HTTP/2 spec.

Refs: https://nodejs.org/api/http2.html\#http2sessionclosecallback
PR-URL: https://github.com/nodejs/node/pull/57808
Fixes: https://github.com/nodejs/node/issues/57809
Refs: https://nodejs.org/api/http2.html%5C#http2sessionclosecallback
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:19 +02:00
Wiyeong Seo
49e624f554
os: fix netmask format check condition in getCIDR function
Modified to check the format of the netmask instead
of just checking that each part of the netmask is even

PR-URL: https://github.com/nodejs/node/pull/57324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:19 +02:00
Luigi Pinca
275ea8e7ef
test: force GC in test-file-write-stream4
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: https://github.com/nodejs/node/pull/57927
PR-URL: https://github.com/nodejs/node/pull/57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-06-11 09:21:19 +02:00
Luigi Pinca
da6a13c338
test: deflake test-http2-options-max-headers-block-length
The socket can be closed while data is still being written, causing an
`ECONNRESET` error to be emitted on the client. Add a listener for it.

PR-URL: https://github.com/nodejs/node/pull/57959
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2025-06-11 09:21:19 +02:00
Paolo Insogna
0556f54544
http: correctly translate HTTP method
PR-URL: https://github.com/nodejs/node/pull/52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-11 09:21:18 +02:00
Shelley Vohr
234a505e96
src: allow embedder customization of OOMErrorHandler
PR-URL: https://github.com/nodejs/node/pull/57325
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2025-06-11 09:21:18 +02:00
Shelley Vohr
c0252cd380
src: fix -Wunreachable-code-return in node_sea
PR-URL: https://github.com/nodejs/node/pull/57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-11 09:21:18 +02:00
ywave620
c2c6d2b035
http: be more generational GC friendly
Avoid any potential ref to Buffer in new generation
from old generation

PR-URL: https://github.com/nodejs/node/pull/56767
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-06-11 09:21:14 +02:00
Antoine du Hamel
0c0fbfa9c6
doc: add missing v0.x changelog entries
PR-URL: https://github.com/nodejs/node/pull/57779
Refs: https://github.com/nodejs/node/releases/tag/v0.11.15
Refs: https://github.com/nodejs/node/releases/tag/v0.11.16
Refs: https://github.com/nodejs/node/releases/tag/v0.12.7
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-06-10 14:32:59 +02:00
Node.js GitHub Bot
01d63a4ddf
deps: update timezone to 2025b
PR-URL: https://github.com/nodejs/node/pull/57857
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-10 14:32:58 +02:00
Node.js GitHub Bot
10fb49f2a9
deps: update icu to 77.1
PR-URL: https://github.com/nodejs/node/pull/57455
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2025-06-10 14:32:58 +02:00
René
e99462c9fc
doc: correct deprecation type of assert.CallTracker
PR-URL: https://github.com/nodejs/node/pull/57997
Refs: https://github.com/nodejs/node/pull/47740
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-10 14:32:58 +02:00
Eng Zer Jun
c7e92696ef
doc: add returns for https.get
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/58025
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2025-06-10 14:32:58 +02:00
Antoine du Hamel
ccc42b69ce
doc: fix env variable name in util.styleText
PR-URL: https://github.com/nodejs/node/pull/58072
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-10 14:32:58 +02:00
René
56fce6691e
test: prevent extraneous HOSTNAME substitution in test-runner-output
PR-URL: https://github.com/nodejs/node/pull/58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-06-10 14:32:57 +02:00
Dario Piotrowicz
b6daa344eb
doc: add dario-piotrowicz to collaborators
PR-URL: https://github.com/nodejs/node/pull/58102
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2025-06-10 14:32:57 +02:00
Naor Tedgi (Abu Emma)
e5d6a3df16
doc: fix AsyncLocalStorage example response changes after node v18
PR-URL: https://github.com/nodejs/node/pull/57969
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-10 14:32:57 +02:00
yusheng chen
f006411998
doc: fix typo of file zlib.md
PR-URL: https://github.com/nodejs/node/pull/58093
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-10 14:32:57 +02:00
Jimmy Leung
5193735df4
doc: add missing options.signal to readlinePromises.createInterface()
From the source code, `readlinePromises.createInterface()` calls
`new Interface()` imported from `internal/readline/interface`, which
works the same as the non-promise version. If non-promise version
accepts options.signal, it should also work for
`readlinePromises.createInterface()`. Hence this information need to be
indicated in the documentation.

Refs: https://github.com/nodejs/node/blob/main/lib/readline/promises.js
PR-URL: https://github.com/nodejs/node/pull/55456
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-06-10 14:32:57 +02:00
Jimmy Leung
fd44af730f
doc: fix misaligned options in vm.compileFunction()
Current alignment mislead doc reader into thinking
`importModuleDynamically` is a separate positional param right next to
`options`, which is incorrect and need to be fixed.

This misalignment is introduced in a PR merged in Feb 2024.

I belive this doc fix applies to node v20 and above.

Refs: https://github.com/nodejs/node/pull/51244
PR-URL: https://github.com/nodejs/node/pull/58145
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
2025-06-10 14:32:57 +02:00
Brian Muenzenmeyer
0fdcc0ddcd
doc: add ambassaor message
PR-URL: https://github.com/nodejs/node/pull/57600
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-06-10 14:32:56 +02:00
RafaelGSS
fc1fa7a357
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
Co-Authored-By: richardlau - Richard Lau <rlau@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/58090
Refs: https://github.com/nodejs/node/issues/57934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2025-06-05 14:05:28 +02:00
Dario Piotrowicz
5ca9616bd3
doc: increase z-index of header element
increase the z-index of the header element to make sure that
opened pickers from it (such as the node version picker) are
on top of other content

PR-URL: https://github.com/nodejs/node/pull/57851
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-06-05 11:14:00 +02:00
Livia Medeiros
81342d10f0
doc: fix deprecation type for DEP0148
PR-URL: https://github.com/nodejs/node/pull/57785
Refs: https://github.com/nodejs/node/pull/40121
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-06-05 11:13:07 +02:00