Commit graph

44071 commits

Author SHA1 Message Date
Antoine du Hamel
bace73a173
doc: update the instruction on how to verify releases
PR-URL: https://github.com/nodejs/node/pull/59113
Fixes: https://github.com/nodejs/node/issues/58904
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-08-04 13:35:57 +02:00
Sungwon
feec26d3bb
test: use mustSucceed in test-fs-read
This commit refactors the callback in test/parallel/test-fs-read.js
to use common.mustSucceed() instead of common.mustCall().

common.mustSucceed() is the preferred helper for standard error-first
callbacks that are expected to succeed, as it provides an explicit
check that the `err` argument is null. This improves the clarity
and robustness of the test.

PR-URL: https://github.com/nodejs/node/pull/59204
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:57 +02:00
Richard Lau
b30a2117dc
build,deps,tools: prepare to update to OpenSSL 3.5
Update the updater script and files under `deps/openssl/config` in
preparation for updating `deps/openssl` to OpenSSL 3.5.

Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/58100
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-08-04 13:35:57 +02:00
Richard Lau
d7e23769ab
test: prepare test-crypto-rsa-dsa for newer OpenSSL
Update `parallel/test-crypto-rsa-dsa` to prepare for updating
`deps/openssl` to later versions of OpenSSL which support implicit
rejections with `RSA_PKCS1_PADDING`.

PR-URL: https://github.com/nodejs/node/pull/58100
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-08-04 13:35:56 +02:00
Mert Can Altin
8615ea6db0
buffer: cache Environment::GetCurrent to avoid repeated calls
PR-URL: https://github.com/nodejs/node/pull/59043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-08-04 13:35:56 +02:00
Alex Yang
3a9aca91c6
test: fix flaky test-worker-message-port-transfer-filehandle test
PR-URL: https://github.com/nodejs/node/pull/59158
Fixes: https://github.com/nodejs/node/issues/59145
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-04 13:35:56 +02:00
Rich Trott
b549deac02
doc: copyedit SECURITY.md
PR-URL: https://github.com/nodejs/node/pull/59190
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:56 +02:00
Allon Murienik
74e1aa4d06
process: make execve's args argument optional
Align the code with the documentation and similar methods used to
execute os commands - the `args` argument should be optional, and if
omitted, treated as an empty array (`[]`).

Fixes: https://github.com/nodejs/node/issues/58411
PR-URL: https://github.com/nodejs/node/pull/58412
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
2025-08-04 13:35:56 +02:00
Rafael Gonzaga
1b9b5bddd6
benchmark: adjust configuration for string-decoder bench
According to https://github.com/nodejs/node/pull/59186 this
benchmark file takes 6 hours to complete a full benchmark/compare.js
script (60 runs in total) and this regression tests unrealitics to do
between Node.js releases. By using calibrate-n scripts I could find
a better N also ajusting some bench configs. e.g: avoid dead code
elimination by V8.

PR-URL: https://github.com/nodejs/node/pull/59187
Refs: https://github.com/nodejs/node/pull/59186
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:56 +02:00
theanarkh
0769e5a0dc
src: call unmask after install signal handler
PR-URL: https://github.com/nodejs/node/pull/59059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-04 13:35:55 +02:00
Joyee Cheung
f9bc2573dd
tools: clarify README linter error message
PR-URL: https://github.com/nodejs/node/pull/59160
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
2025-08-04 13:35:55 +02:00
Rafael Gonzaga
d0ac3319f9
benchmark: add --track to benchmark
This option will measure how long the benchmark
takes to run. Example:

```
$ ./node benchmark/run.js --track assert

assert/assertion-error.js
assert/assertion-error.js size=2 n=200: 22,987.24012781365
assert/assertion-error.js size=75 n=200: 296.2362823364434
[740ms] assert/assertion-error.js

...
```

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/59174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2025-08-04 13:35:55 +02:00
Rafael Gonzaga
2044968b86
benchmark: small lint fix on _cli.js
PR-URL: https://github.com/nodejs/node/pull/59172
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2025-08-04 13:35:55 +02:00
Rafael Gonzaga
4e519934cb
benchmark: drop misc/punycode benchmark
punycode has been deprecated and icu.toASCII
method does not exist. This benchmark file
has been failing for a while.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/59171
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:55 +02:00
Rafael Gonzaga
07e173d969
benchmark: fix sqlite-is-transaction
The variable deadCodeElimination is declared
but not initialized, making it undefined by default.
When using the &&= operator with an undefined left operand,
the result will always remain undefined regardless of
how many iterations run.

```js
let deadCodeElimination;
deadCodeElimination &&= true
deadCodeElimination // undefined
```

PR-URL: https://github.com/nodejs/node/pull/59170
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
2025-08-04 13:35:55 +02:00
Superchupu
ef1bc3f344
doc: fix broken sentence in URL.parse
PR-URL: https://github.com/nodejs/node/pull/59164
Refs: https://developer.mozilla.org/en-US/docs/Web/API/URL/parse_static#return_value
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:54 +02:00
Haram Jeong
e592d739c2
cli: support ${pid} placeholder in --cpu-prof-name
PR-URL: https://github.com/nodejs/node/pull/59072
Fixes: https://github.com/nodejs/node/issues/57418
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-04 13:35:54 +02:00
Antoine du Hamel
cba0de128d
tools: add support for URLs to PR commits in merge.sh
PR-URL: https://github.com/nodejs/node/pull/59162
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2025-08-04 13:35:54 +02:00
Joyee Cheung
3c6639e8ec
doc: improve onboarding instructions
- Explains Jenkins CI
- Document how to make the PR appear as "merged" if landed manually
- Explain what other repositories are for.
- Mention reliability repo and CI flakes

PR-URL: https://github.com/nodejs/node/pull/59159
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:54 +02:00
Rafael Gonzaga
6ffaac66bc
doc: add constraints for mem leak to threat model
As discussed in https://github.com/nodejs-private/node-private/pull/719.

We should clarify what the criteria are to accept
memory leak as a vulnerability (potential DoS).

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/58917
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-04 13:35:54 +02:00
Alex Yang
e22dddf859
util: respect nested formats in styleText
Co-authored-by: Jordan Harband <ljharb@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/59098
Fixes: https://github.com/nodejs/node/issues/59035
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2025-08-04 13:35:54 +02:00
Anna Henningsen
1e7639e9e1
src: use FastStringKey for TrackV8FastApiCall
This is the exact intended use case of `FastStringKey`.

PR-URL: https://github.com/nodejs/node/pull/59148
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
2025-08-04 13:35:54 +02:00
Anna Henningsen
9075a1a4bf
src: use C++20 consteval for FastStringKey
This makes it easier to avoid unintentional mis-usage of the API.

PR-URL: https://github.com/nodejs/node/pull/59148
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
2025-08-04 13:35:53 +02:00
Anna Henningsen
3aee7625b9
test: expand linting rules around assert w literal messages
Expands the existing restrictions around not using literal messages
to the `not` variants of `strictEqual` and `deepStrictEqual`, and
forbids `assert()` where the second argument is a non-string literal,
which almost always is a mis-typed `assert.strictEquals()`.

PR-URL: https://github.com/nodejs/node/pull/59147
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-08-04 13:35:53 +02:00
Node.js GitHub Bot
251b65dd6c
meta: move one or more collaborators to emeritus
PR-URL: https://github.com/nodejs/node/pull/59140
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2025-08-04 13:35:53 +02:00
Node.js GitHub Bot
e8da171cc3
deps: update sqlite to 3.50.3
PR-URL: https://github.com/nodejs/node/pull/59132
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-08-04 13:35:53 +02:00
Node.js GitHub Bot
fd4ba38ab6
deps: update googletest to 7e17b15
PR-URL: https://github.com/nodejs/node/pull/59131
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2025-08-04 13:35:53 +02:00
Anna Henningsen
5a0fd5689b
src: remove declarations of removed BaseObject static fns
These were removed in 5c86f223ae, so their declarations should be
removed from class declarations too.

PR-URL: https://github.com/nodejs/node/pull/59093
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
2025-08-04 13:35:52 +02:00
dependabot[bot]
039949ef5b
tools: bump @eslint/plugin-kit from 0.3.1 to 0.3.3 in /tools/eslint
Bumps [@eslint/plugin-kit](https://github.com/eslint/rewrite/tree/HEAD/packages/plugin-kit) from 0.3.1 to 0.3.3.
- [Release notes](https://github.com/eslint/rewrite/releases)
- [Changelog](https://github.com/eslint/rewrite/blob/main/packages/plugin-kit/CHANGELOG.md)
- [Commits](https://github.com/eslint/rewrite/commits/plugin-kit-v0.3.3/packages/plugin-kit)

---
updated-dependencies:
- dependency-name: "@eslint/plugin-kit"
  dependency-version: 0.3.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/59119
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-08-04 13:35:52 +02:00
René
8d60602677
perf_hooks: do not expose SafeMap via Histogram wrapper
PR-URL: https://github.com/nodejs/node/pull/59094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-08-04 13:35:52 +02:00
Aditi
e419d20144
doc: add Aditi-1400 to collaborators
Fixes: https://github.com/nodejs/node/issues/59064
PR-URL: https://github.com/nodejs/node/pull/59157
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
2025-08-04 13:35:52 +02:00
Node.js GitHub Bot
667c2ced38
test: update WPT for WebCryptoAPI to ab08796857
PR-URL: https://github.com/nodejs/node/pull/59129
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-04 13:35:52 +02:00
Node.js GitHub Bot
89ac344393
test: update WPT for WebCryptoAPI to 19d82c57ab
PR-URL: https://github.com/nodejs/node/pull/59129
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-04 13:35:51 +02:00
Node.js GitHub Bot
f71f427b95
deps: update archs files for openssl-3.0.17
PR-URL: https://github.com/nodejs/node/pull/59134
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:51 +02:00
Node.js GitHub Bot
79c5a8f4d2
deps: upgrade openssl sources to openssl-3.0.17
PR-URL: https://github.com/nodejs/node/pull/59134
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:51 +02:00
Node.js GitHub Bot
0dcc84cf53
deps: update corepack to 0.34.0
PR-URL: https://github.com/nodejs/node/pull/59133
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2025-08-04 13:35:51 +02:00
Ilyas Shabi
c637a2c41d
src: add cache to nearest parent package json
PR-URL: https://github.com/nodejs/node/pull/59086
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-08-04 13:35:50 +02:00
Abdirahim Musse
d332957ac6
test: skip tests that cause timeouts on IBM i
I missed marking a couple of test cases flaky in my previous PR:
https://github.com/nodejs/node/pull/58583

tests missed were:

- parallel.test-inspector-network-content-type
- benchmark.test-benchmark-websocket

After marking the above flaky I re-ran a test build and noticed
the build still failed.

Unfortuantely the build still fails because the build detects that
node process are left behind after the tests, presumably because tests
that spawn child processes are being timed out and only the parent
process is killed off, leaving the child processes behind.

see: https://github.com/nodejs/node/pull/59014#issuecomment-3057162303

We've decided to skip these tests until the underlying issue is
resolved.

The tests being skipped are:
- parallel.test-http-proxy-fetch
- parallel.test-https-proxy-fetch
- benchmark.test-benchmark-websocket
- parallel.test-inspector-network-fetch
- parallel.test-inspector-network-content-type
- es-module.test-wasm-web-api
- parallel.test-fetch
- parallel.test-without-async-context-frame
- report.test-report-exclude-network

PR-URL: https://github.com/nodejs/node/pull/59014
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2025-08-04 13:35:50 +02:00
Chengzhong Wu
ba380f7bf3
doc: avoid suggesting testing fast api with intense loop
PR-URL: https://github.com/nodejs/node/pull/59111
Refs: https://github.com/nodejs/node/pull/59055
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
2025-08-04 13:35:50 +02:00
SeokHun
fa1a532f2b
doc: fix typo in writing-test.md
Corrects the misspelling of "optimial" to "optimal".

PR-URL: https://github.com/nodejs/node/pull/59123
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-08-04 13:35:50 +02:00
Arthur Angelo
8440b6177f
benchmark: reduce N for diagnostics_channel subscribe benchmark
Signed-off-by: artimmy <arthurtimmy@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/59116
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:35:50 +02:00
Dario Piotrowicz
a23562ff72
test: update startCLI to set --port=0 by default
update the `startCLI` debugging testing utility to set by default
the port to use to `0` (i.e. a random port)

PR-URL: https://github.com/nodejs/node/pull/59042
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-08-04 13:35:50 +02:00
Joyee Cheung
cda1dab6e2
crypto: add tls.setDefaultCACertificates()
This API allows dynamically configuring CA certificates that
will be used by the Node.js TLS clients by default.

Once called, the provided certificates will become the default CA
certificate list returned by `tls.getCACertificates('default')` and
used by TLS connections that don't specify their own CA certificates.

This function only affects the current Node.js thread.

PR-URL: https://github.com/nodejs/node/pull/58822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-08-04 13:29:04 +02:00
Chengzhong Wu
ff6be2ed5d
node-api,doc: update links to ecma262 with section names
Section numbers can change over time. Use the section names as the link
text for better readability.

Also, use https://tc39.es/ecma262/ as the unified host of living version
of ECMA-262.

PR-URL: https://github.com/nodejs/node/pull/59087
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
2025-08-04 13:29:04 +02:00
Joyee Cheung
4a12f5d83b
test: mark test-inspector-network-fetch as flaky on Windows
PR-URL: https://github.com/nodejs/node/pull/59091
Refs: https://github.com/nodejs/node/issues/59090
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2025-08-04 13:29:04 +02:00
Rafael Gonzaga
0f0ce63116
build: remove suppressions.supp
We have removed the UBSan workflow
and there's no ongoing initiative to
bring it back.

PR-URL: https://github.com/nodejs/node/pull/59079
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:29:04 +02:00
Rafael Gonzaga
0b93ca3d19
doc: add RafaelGSS as steward July 25
PR-URL: https://github.com/nodejs/node/pull/59078
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-08-04 13:29:04 +02:00
Antoine du Hamel
d0f40f3a3a
tools,test: enforce best practices to detect never settling promises
PR-URL: https://github.com/nodejs/node/pull/58992
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-04 13:29:04 +02:00
Haram Jeong
7d747aeac8
doc: clarify ERR_FS_FILE_TOO_LARGE to reflect fs.readFile() I/O limit
PR-URL: https://github.com/nodejs/node/pull/59050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2025-08-04 13:29:03 +02:00
github-actions[bot]
0b5613f9fe
doc: run license-builder
PR-URL: https://github.com/nodejs/node/pull/59056
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-08-04 13:29:03 +02:00