Commit graph

34888 commits

Author SHA1 Message Date
Rich Trott
86099a375a tools: avoid unnecessary escaping in markdown formatter
Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary
escaping of `_` and some other characters. Re-run markdown formatter.

PR-URL: https://github.com/nodejs/node/pull/40645
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-10-31 09:36:05 -07:00
Rich Trott
571e0b1b3f doc: final round of markdown format changes
Once the README and find-inactive-collaborators.mjs changes land here,
we can introduce markdown formatting as a step in the toolchain
somewhere.

Before this lands, https://github.com/nodejs/node-core-utils/pull/578
will need to land and be included in a node-core-utils release.

PR-URL: https://github.com/nodejs/node/pull/40645
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-10-31 09:36:02 -07:00
Rich Trott
1a6d92728f tools,meta: remove exclusions from AUTHORS
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: https://github.com/nodejs/node/pull/232#discussion-diff-22412788

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.

PR-URL: https://github.com/nodejs/node/pull/40648
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-10-31 15:23:21 +00:00
Mestery
61a73f80c7
typings: add more bindings typings
PR-URL: https://github.com/nodejs/node/pull/40415
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-10-31 13:41:45 +01:00
FrankQiu
b63313ae43
doc: remove --experimental-modules documentation
PR-URL: https://github.com/nodejs/node/pull/38974
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-31 13:17:37 +01:00
Voltrex
8768012370
typings: add JSDoc typings for inspector
Added JSDoc typings for the `inspector` lib module.

PR-URL: https://github.com/nodejs/node/pull/38390
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-10-31 13:14:33 +01:00
Antoine du Hamel
b5aa08d2f9
tools: avoid fetch extra commits when validating commit messages
PR-URL: https://github.com/nodejs/node/pull/39128
Reviewed-By: Mary Marchini <oss@mmarchini.me>
2021-10-30 17:45:25 +02:00
Darshan Sen
f8035ecbbd src: remove usage of AllocatedBuffer from node_http2
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/40584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2021-10-30 08:46:10 +00:00
Darshan Sen
ff536fa13e test: test crypto.setEngine() using an actual engine
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/40481
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-30 08:46:02 +00:00
Rich Trott
babd73ce25 meta: consolidate AUTHORS entries for brettkiefer
PR-URL: https://github.com/nodejs/node/pull/40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
2021-10-30 00:19:38 +00:00
Joyee Cheung
e937662dec doc: update tracking issues of startup performance
The issues listed in the doc have been closed, and a new one is
currently being used to track snapshot integration.

PR-URL: https://github.com/nodejs/node/pull/40629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-28 20:26:48 +00:00
ryan
17d0830cf8 doc: fix markdown syntax and HTML tag misses
PR-URL: https://github.com/nodejs/node/pull/40608
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
2021-10-28 09:22:57 -07:00
Tobias Nießen
f3125cf301 src: fix #endif description in crypto_keygen.h
PR-URL: https://github.com/nodejs/node/pull/40639
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-28 07:59:47 -07:00
Tobias Nießen
f7209eeab6 test: use conventional argument order in assertion
PR-URL: https://github.com/nodejs/node/pull/40591
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-28 07:56:58 -07:00
Rich Trott
1306d5ca28 meta: consolidate AUTHORS entries for alexzherdev
PR-URL: https://github.com/nodejs/node/pull/40620
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-28 14:28:44 +00:00
Rich Trott
3a74481225 meta: consolidate AUTHORS entries for Azard
PR-URL: https://github.com/nodejs/node/pull/40619
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-28 14:28:35 +00:00
Mestery
b66a75a3a4 typings: improve internal bindings typings
PR-URL: https://github.com/nodejs/node/pull/40411
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-28 07:52:29 +00:00
Mestery
3ff8c355c8 doc: use 'GitHub Actions workflow' instead
PR-URL: https://github.com/nodejs/node/pull/40586
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2021-10-27 19:51:55 -07:00
Tobias Nießen
2a71eb75db doc: ref OpenSSL legacy provider from crypto docs
This adds a link to the --openssl-legacy-provider flag to the
"Support for weak or compromised algorithms" section.

PR-URL: https://github.com/nodejs/node/pull/40593
Refs: https://github.com/nodejs/node/pull/40478
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
2021-10-27 18:32:15 +00:00
Daniel Nalborczyk
e55ab893e4 doc: add node: url scheme
PR-URL: https://github.com/nodejs/node/pull/40573
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
2021-10-27 09:15:20 +00:00
Daniel Nalborczyk
3165eb9dc8 doc: call cwd function
PR-URL: https://github.com/nodejs/node/pull/40573
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
2021-10-27 09:15:19 +00:00
Daniel Nalborczyk
3d163d3214 doc: remove unused imports
PR-URL: https://github.com/nodejs/node/pull/40573
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
2021-10-27 09:15:18 +00:00
Rich Trott
9c405f2591 doc: simplify CHANGELOG.md
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: https://github.com/nodejs/node/pull/40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2021-10-26 23:35:51 +00:00
Guy Bedford
687debbf0a doc: correct esm spec scope lookup definition
PR-URL: https://github.com/nodejs/node/pull/40592
Fixes: https://github.com/nodejs/node/issues/40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
2021-10-26 16:02:54 -07:00
Richard Lau
34d810c060 doc: update CHANGELOG.md for Node.js 16.13.0
Update missed changes for the main CHANGELOG.md for Node.js 16.13.0.

PR-URL: https://github.com/nodejs/node/pull/40617
Refs: https://github.com/nodejs/node/pull/40536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-10-26 11:54:56 -07:00
Luigi Pinca
a7847960c2 tools: update ESLint to 8.1.0
PR-URL: https://github.com/nodejs/node/pull/40582
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2021-10-26 17:58:17 +00:00
Richard Lau
506f7de440
2021-10-26, Version 16.13.0 'Gallium' (LTS)
Notable changes:

This release marks the transition of Node.js 16.x into Long Term Support (LTS)
with the codename 'Gallium'. The 16.x release line now moves into "Active LTS"
and will remain so until October 2022. After that time, it will move into
"Maintenance" until end of life in April 2024.

PR-URL: https://github.com/nodejs/node/pull/40536
2021-10-26 12:11:04 -04:00
Rich Trott
d4842e64bb tools: fix formatting of warning message in update-authors.js
The email already has `<` and `>` surrounding it so adding it results in
a misformatted message.

PR-URL: https://github.com/nodejs/node/pull/40600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-10-26 10:07:14 +00:00
Michael Dawson
9ebdba49c7 doc: add info on project's usage of coverity
Document project's used of coverity and how
collaborators can get access.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/40506
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2021-10-25 16:43:40 -04:00
Jeremiah Senkpiel
7c2b4906fa meta: move Fishrock123 to emeritus
I've moved on. I do not wish to be responsible for anything here and
have been inactive for more than a year.

PR-URL: https://github.com/nodejs/node/pull/40596
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
2021-10-25 18:20:32 +00:00
Rich Trott
a2d65c0351 meta: consolidate AUTHORS entries for clakech
PR-URL: https://github.com/nodejs/node/pull/40589
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
2021-10-25 18:20:21 +00:00
Luigi Pinca
b88de12bfb doc: fix typo in changelogs
Fix typo in v12.22.7, v14.18.1, and v16.11.1 changelogs.

PR-URL: https://github.com/nodejs/node/pull/40585
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
2021-10-25 16:26:12 +00:00
Nitzan Uziely
2413283f55 dgram: fix send with out of bounds offset + length
fix Socket.prototype.send sending garbage when the message is a string,
or Buffer and offset+length is out of bounds.

Fixes: https://github.com/nodejs/node/issues/40491

PR-URL: https://github.com/nodejs/node/pull/40568
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-10-25 13:26:24 +00:00
Robert Nagy
3b9044b5b2 http: response should always emit 'close'
Fixes: https://github.com/nodejs/node/issues/40528

PR-URL: https://github.com/nodejs/node/pull/40543
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-10-25 07:35:24 +00:00
Rich Trott
070b54a4ac policy: fix message for invalid manifest specifier
Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

PR-URL: https://github.com/nodejs/node/pull/40574
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
2021-10-24 22:41:28 -07:00
Guy Bedford
f0dcac89c7 module: resolver & spec hardening /w refactoring
PR-URL: https://github.com/nodejs/node/pull/40510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-24 14:44:59 -07:00
Rich Trott
8eebc33c02 build: skip long-running Actions for README-only modifications
If the only file modified is README.md do not run test-linux or
build-windows tasks. This will help streamline onboarding sessions but
may help some other cases too.

PR-URL: https://github.com/nodejs/node/pull/40571
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-24 19:01:18 +00:00
Rich Trott
566365dd9d doc: update onboarding task
Make starting Jenkins CI optional.

PR-URL: https://github.com/nodejs/node/pull/40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-24 19:01:07 +00:00
Rich Trott
ce0e21e50a meta: consolidate AUTHORS entries for darai0512
PR-URL: https://github.com/nodejs/node/pull/40569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-10-24 19:00:56 +00:00
Rich Trott
31d7d6c994 doc: simplify ccache instructions
`ccache` has reasonable defaults for `max_size` and `cache_dir` so
remove instructions to set those things explicitly.

Change fenced code from `console` to `bash` for easier copy/paste.

PR-URL: https://github.com/nodejs/node/pull/40550
Fixes: https://github.com/nodejs/node/issues/40542
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-10-24 06:59:22 -07:00
Rich Trott
edd716beb1 doc: fix macOS environment variables for ccache
macOS requires `cc` and `c++` rather than `gcc` and `g++`.

Closes: https://github.com/nodejs/node/issues/40542

PR-URL: https://github.com/nodejs/node/pull/40550
Fixes: https://github.com/nodejs/node/issues/40542
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-10-24 06:59:20 -07:00
Michaël Zasso
40d890d31d doc: improve async_context introduction
- Rename "Async_context" to "Asynchronous context tracking" in toc.
- Use named imports to show how `AsyncLocalStorage` and `AsyncResource`
  can be imported.

PR-URL: https://github.com/nodejs/node/pull/40560
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2021-10-24 12:36:03 +00:00
Node.js GitHub Bot
dd9f729d5f
meta: update AUTHORS
PR-URL: https://github.com/nodejs/node/pull/40580
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
2021-10-23 23:17:13 -07:00
Robert Nagy
47fb8676ff stream: remove no longer necessary ComposeDuplex
PR-URL: https://github.com/nodejs/node/pull/40545
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2021-10-23 22:23:35 +00:00
npm team
9843885e93 deps: upgrade npm to 8.1.1
PR-URL: https://github.com/nodejs/node/pull/40554
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2021-10-23 06:17:03 -07:00
Rich Trott
a749c1f20c doc: use GFM footnotes in webcrypto.md
PR-URL: https://github.com/nodejs/node/pull/40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-10-23 06:13:21 -07:00
Rich Trott
179248a7b9 tools: udpate doc tools to accommodate GFM footnotes
PR-URL: https://github.com/nodejs/node/pull/40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-10-23 06:13:18 -07:00
Cheng Zhao
a536de4695
build: disable v8 pointer compression on 32bit archs
PR-URL: https://github.com/nodejs/node/pull/40418
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2021-10-23 08:52:55 +02:00
Richie Bendall
f1940824d9
tty: support more CI services in getColorDepth
PR-URL: https://github.com/nodejs/node/pull/40385
Refs: https://github.com/sindresorhus/yoctocolors/pull/5
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2021-10-23 08:50:56 +02:00
Ray Wang
14f6c67eda
doc: describe buffer limit of v8.serialize
PR-URL: https://github.com/nodejs/node/pull/40243
Fixes: https://github.com/nodejs/node/issues/40059
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-10-23 08:47:19 +02:00