Remove unnecessary skip checks (#13637)

This commit is contained in:
Kamil Tekiela 2024-03-08 16:59:51 +01:00 committed by GitHub
parent c412919c93
commit 6fb1c7a742
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
28 changed files with 97 additions and 175 deletions

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!defined("MYSQLI_ASYNC")) {
die("skip mysqlnd only");
}
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!defined("MYSQLI_ASYNC")) {
die("skip mysqlnd only");
}
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -6,7 +6,6 @@ mysqli
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (PHP_INT_SIZE != 8) die('skip requires 64-bit'); if (PHP_INT_SIZE != 8) die('skip requires 64-bit');
if (!defined('MYSQLI_OPT_INT_AND_FLOAT_NATIVE')) die('skip requires mysqlnd');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,7 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!defined('MYSQLI_STORE_RESULT_COPY_DATA')) die('skip requires mysqlnd');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -6,7 +6,6 @@ mysqli
<?php <?php
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test"); if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!defined('MYSQLI_STORE_RESULT_COPY_DATA')) die('skip requires mysqlnd');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,7 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!defined('MYSQLI_STORE_RESULT_COPY_DATA')) die('skip requires mysqlnd');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -9,13 +9,8 @@ echo constant('MYSQLI_NO_DATA')."\n";
echo constant('MYSQLI_DATA_TRUNCATED')."\n"; echo constant('MYSQLI_DATA_TRUNCATED')."\n";
echo constant('MYSQLI_SERVER_QUERY_NO_GOOD_INDEX_USED')."\n"; echo constant('MYSQLI_SERVER_QUERY_NO_GOOD_INDEX_USED')."\n";
echo constant('MYSQLI_SERVER_QUERY_NO_INDEX_USED')."\n"; echo constant('MYSQLI_SERVER_QUERY_NO_INDEX_USED')."\n";
if (stristr(mysqli_get_client_info(), 'mysqlnd')) { echo constant('MYSQLI_SERVER_QUERY_WAS_SLOW')."\n";
echo constant('MYSQLI_SERVER_QUERY_WAS_SLOW')."\n"; echo constant('MYSQLI_SERVER_PS_OUT_PARAMS')."\n";
echo constant('MYSQLI_SERVER_PS_OUT_PARAMS')."\n";
} else {
print("\nDeprecated: Constant MYSQLI_SERVER_QUERY_WAS_SLOW is deprecated in dummy\n-1\n");
print("\nDeprecated: Constant MYSQLI_SERVER_PS_OUT_PARAMS is deprecated in dummy\n-1\n");
}
echo constant('MYSQLI_IS_MARIADB')."\n"; echo constant('MYSQLI_IS_MARIADB')."\n";
?> ?>

View file

@ -95,8 +95,7 @@ require_once 'skipifconnectfailure.inc';
var_dump($fields); var_dump($fields);
} }
if (function_exists('mysqli_stmt_get_result') && if ($stmt->prepare('EXPLAIN SELECT t1.*, t2.* FROM test AS t1, test AS t2') &&
$stmt->prepare('EXPLAIN SELECT t1.*, t2.* FROM test AS t1, test AS t2') &&
$stmt->execute()) { $stmt->execute()) {
if (!$res_stmt = mysqli_stmt_get_result($stmt)) { if (!$res_stmt = mysqli_stmt_get_result($stmt)) {
printf("[017] Cannot fetch result from PS [%d] %s\n", printf("[017] Cannot fetch result from PS [%d] %s\n",

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?PHP <?PHP
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_get_client_stats')) {
die("skip only available with mysqlnd");
}
?> ?>
--INI-- --INI--
mysqlnd.collect_statistics=1 mysqlnd.collect_statistics=1

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?PHP <?PHP
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_get_client_stats')) {
die("skip only available with mysqlnd");
}
?> ?>
--INI-- --INI--
mysqlnd.collect_statistics=1 mysqlnd.collect_statistics=1

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?PHP <?PHP
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_get_client_stats')) {
die("skip only available with mysqlnd");
}
?> ?>
--INI-- --INI--
mysqlnd.collect_statistics=0 mysqlnd.collect_statistics=0

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?PHP <?PHP
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_get_client_stats')) {
die("skip only available with mysqlnd");
}
?> ?>
--INI-- --INI--
mysqlnd.collect_statistics=1 mysqlnd.collect_statistics=1

View file

@ -8,9 +8,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?PHP <?PHP
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_get_client_stats')) {
die("skip only available with mysqlnd");
}
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -8,9 +8,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?PHP <?PHP
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_get_connection_stats')) {
die("skip only available with mysqlnd");
}
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -8,9 +8,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?PHP <?PHP
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_get_connection_stats')) {
die("skip only available with mysqlnd");
}
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -63,8 +63,6 @@ if (mysqli_get_server_version($link) <= 50000) {
} }
if (function_exists('mysqli_stmt_get_result')) {
if (!mysqli_query($link, 'DROP PROCEDURE IF EXISTS p')) if (!mysqli_query($link, 'DROP PROCEDURE IF EXISTS p'))
printf("[019] [%d] %s.\n", mysqli_errno($link), mysqli_error($link)); printf("[019] [%d] %s.\n", mysqli_errno($link), mysqli_error($link));
@ -100,8 +98,6 @@ if (mysqli_get_server_version($link) <= 50000) {
printf("[027] Cannot create SP, [%d] %s.\n", mysqli_errno($link), mysqli_error($link)); printf("[027] Cannot create SP, [%d] %s.\n", mysqli_errno($link), mysqli_error($link));
} }
}
if (!mysqli_query($link, 'DROP PROCEDURE IF EXISTS p')) if (!mysqli_query($link, 'DROP PROCEDURE IF EXISTS p'))
printf("[028] [%d] %s.\n", mysqli_errno($link), mysqli_error($link)); printf("[028] [%d] %s.\n", mysqli_errno($link), mysqli_error($link));

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die('skip mysqli_stmt_get_result not available');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,8 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die('skip mysqli_stmt_get_result not available');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -4,10 +4,6 @@ Fetching BIT column values using the PS API
mysqli mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
if (!function_exists('mysqli_stmt_get_result')) {
die("skip mysqli_stmt_get_result() not available");
}
require_once 'connect.inc'; require_once 'connect.inc';
if (!$link = @my_mysqli_connect($host, $user, $passwd, $db, $port, $socket)) { if (!$link = @my_mysqli_connect($host, $user, $passwd, $db, $port, $socket)) {
die(sprintf("skip Can't connect to MySQL Server - [%d] %s", mysqli_connect_errno(), mysqli_connect_error())); die(sprintf("skip Can't connect to MySQL Server - [%d] %s", mysqli_connect_errno(), mysqli_connect_error()));

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die('skip mysqli_stmt_get_result not available');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -6,9 +6,6 @@ mysqli
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die("skip mysqli_stmt_get_result() not available");
if (!defined("MYSQLI_TYPE_GEOMETRY")) if (!defined("MYSQLI_TYPE_GEOMETRY"))
die("skip MYSQLI_TYPE_GEOMETRY not defined"); die("skip MYSQLI_TYPE_GEOMETRY not defined");
?> ?>

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die('skip mysqli_stmt_get_result not available');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die('skip mysqli_stmt_get_result not available');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die('skip mysqli_stmt_get_result not available');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die('skip mysqli_stmt_get_result not available');
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!function_exists('mysqli_stmt_get_result'))
die("skip mysqli_stmt_get_result() not available");
?> ?>
--FILE-- --FILE--
<?php <?php

View file

@ -83,8 +83,6 @@ die("skip Check again when the Klingons visit earth - http://bugs.mysql.com/bug.
} }
} }
if (function_exists('mysqli_stmt_get_result')) {
/* mysqlnd only */
if (!mysqli_stmt_execute($stmt)) { if (!mysqli_stmt_execute($stmt)) {
printf("[%04d - %s] [%d] %s\n", printf("[%04d - %s] [%d] %s\n",
$offset + 6, $sql, $offset + 6, $sql,
@ -163,8 +161,6 @@ die("skip Check again when the Klingons visit earth - http://bugs.mysql.com/bug.
var_dump($meta); var_dump($meta);
} }
}
mysqli_stmt_close($stmt); mysqli_stmt_close($stmt);
return true; return true;
} }

View file

@ -5,9 +5,6 @@ mysqli
--SKIPIF-- --SKIPIF--
<?php <?php
require_once 'skipifconnectfailure.inc'; require_once 'skipifconnectfailure.inc';
if (!defined('MYSQLI_STORE_RESULT_COPY_DATA')) {
die("skip Requires MYSQLI_STORE_RESULT_COPY_DATA");
}
?> ?>
--FILE-- --FILE--
<?php <?php