archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

check_parameters.php: Make the script's retval reflect errors

Browse source 
When the check_parameters.php script meets an error it prints it
out but the exit value is not affected, it's still 0. This does
not fly with projects that want to run this script as a part of
their test suite.

Therefore, make the script return 0 on success and 2 if any error
was reported.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Closes GH-8790.
This commit is contained in:
Michal Prívozník 2022-06-16 15:34:37 +02:00 • committed by GitHub
parent f25afaf9ea
commit a87f4dd930
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scripts/dev/check_parameters.php
View file

@ -51,7 +51,7 @@ $API_params = array(
/** reports an error, according to its level */ /** reports an error, according to its level */
function error($str, $level = 0) function error($str, $level = 0)
{ {
global $current_file, $current_function, $line; global $current_file, $current_function, $line, $error_reported;
if ($level <= REPORT_LEVEL) { if ($level <= REPORT_LEVEL) {
if (strpos($current_file,PHPDIR) === 0) { if (strpos($current_file,PHPDIR) === 0) {
@ -60,6 +60,7 @@ function error($str, $level = 0)
$filename = $current_file; $filename = $current_file;
} }
echo $filename , " [$line] $current_function : $str\n"; echo $filename , " [$line] $current_function : $str\n";
$error_reported = true;
} }
} }
@ -372,6 +373,9 @@ foreach($dirs as $dir) {
} }
} }
$error_reported = false;
foreach ($dirs as $dir) { foreach ($dirs as $dir) {
recurse(realpath($dir)); recurse(realpath($dir));
} }
exit($error_reported === false ? 0 : 2);