archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use zend_parse_parameters_none() in XmlWriter::openMemory()

Browse source 
And fix incorrect uses in tests
This commit is contained in:
Nikita Popov 2019-02-20 09:31:08 +01:00
parent 6e17fbefde
commit d94a1907b7
3 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ext/xmlwriter/php_xmlwriter.c
View file

@ -1700,6 +1700,10 @@ static PHP_FUNCTION(xmlwriter_open_memory)
zval *self = getThis(); zval *self = getThis();
ze_xmlwriter_object *ze_obj = NULL; ze_xmlwriter_object *ze_obj = NULL;
if (zend_parse_parameters_none() == FAILURE) {
return;
}
if (self) { if (self) {
/* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here */ /* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here */
ze_obj = Z_XMLWRITER_P(self); ze_obj = Z_XMLWRITER_P(self);

3
ext/xmlwriter/tests/002.phpt
View file

@ -5,8 +5,7 @@ XMLWriter: libxml2 XML Writer, membuffer, flush
--FILE-- --FILE--
<?php <?php
$doc_dest = '002.xml'; $xw = xmlwriter_open_memory();
$xw = xmlwriter_open_memory($doc_dest);
xmlwriter_start_document($xw, '1.0', 'UTF-8'); xmlwriter_start_document($xw, '1.0', 'UTF-8');
xmlwriter_start_element($xw, "tag1"); xmlwriter_start_element($xw, "tag1");
xmlwriter_end_document($xw); xmlwriter_end_document($xw);

3
ext/xmlwriter/tests/003.phpt
View file

@ -5,8 +5,7 @@ XMLWriter: libxml2 XML Writer, membuffer, flush, attribute
--FILE-- --FILE--
<?php <?php
$doc_dest = '003.xml'; $xw = xmlwriter_open_memory();
$xw = xmlwriter_open_memory($doc_dest);
xmlwriter_start_document($xw, '1.0', 'UTF-8'); xmlwriter_start_document($xw, '1.0', 'UTF-8');
xmlwriter_start_element($xw, "tag1"); xmlwriter_start_element($xw, "tag1");