archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 21:48:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ext/gettext: Remove duplicate domain length checks

Browse source 
It not being empty is already checked by PHP_GETTEXT_DOMAIN_LENGTH_CHECK()
This commit is contained in:
Gina Peter Bnayard 2024-08-18 20:10:12 +02:00 • committed by Gina Peter Banyard
parent 10738141d7
commit f6c464fee5
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
ext/gettext/gettext.c
View file

@ -190,11 +190,6 @@ PHP_FUNCTION(bindtextdomain)
PHP_GETTEXT_DOMAIN_LENGTH_CHECK(1, ZSTR_LEN(domain)) PHP_GETTEXT_DOMAIN_LENGTH_CHECK(1, ZSTR_LEN(domain))
if (!ZSTR_LEN(domain)) {
zend_argument_cannot_be_empty_error(1);
RETURN_THROWS();
}
if (dir == NULL) { if (dir == NULL) {
RETURN_STRING(bindtextdomain(ZSTR_VAL(domain), NULL)); RETURN_STRING(bindtextdomain(ZSTR_VAL(domain), NULL));
} }
@ -312,11 +307,6 @@ PHP_FUNCTION(bind_textdomain_codeset)
PHP_GETTEXT_DOMAIN_LENGTH_CHECK(1, ZSTR_LEN(domain)) PHP_GETTEXT_DOMAIN_LENGTH_CHECK(1, ZSTR_LEN(domain))
if (!ZSTR_LEN(domain)) {
zend_argument_cannot_be_empty_error(1);
RETURN_THROWS();
}
retval = bind_textdomain_codeset(ZSTR_VAL(domain), codeset ? ZSTR_VAL(codeset) : NULL); retval = bind_textdomain_codeset(ZSTR_VAL(domain), codeset ? ZSTR_VAL(codeset) : NULL);
if (!retval) { if (!retval) {