Commit graph

35636 commits

Author SHA1 Message Date
nobu
b901b87543 test_string.rb: move and add assertions
* test/ruby/test_string.rb (test_slice): move the assertion for
  [Bug #9882], and more assertion for `ascii_only?` too, as
  pointed out by Heesob Park in [ruby-core:62846].

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 02:55:26 +00:00
nobu
950508e9b7 string.c: reset code range
* string.c (rb_str_substr): need to reset code range for shared
  string too, not only copied string.
  [ruby-core:62842] [Bug #9882]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 02:33:38 +00:00
nobu
361978beb2 test_beginendblock.rb: avoid leaking threads
* test/ruby/test_beginendblock.rb (test_endblock_raise): not only
  kill, but also wait the end.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 02:32:37 +00:00
nobu
4e741f4b89 erb.rb: ERB#result does not accept a proc.
* lib/erb.rb (result): [DOC] no longer accepts a Proc, as
  Kernel.eval does not.  [fix GH-619]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 01:22:23 +00:00
akr
83ead3c4a7 * ext/-test-/dir: Dir#fileno implemented.
* test/lib/minitest/unit.rb (find_fds): Don't return the fd used to
  scan /proc/$$/fd.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 22:28:47 +00:00
normal
fae18c95be remove empty rb_gc_mark_parser function
* parse.y (rb_gc_mark_parser): remove, empty since r8758
* internal.h: ditto, not usable from extensions since 2.0.0
* gc.c (gc_mark_roots): remove checkpoint for parser

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 19:49:22 +00:00
svn
d2684fd18e * 2014-05-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 15:45:29 +00:00
usa
6c42f57177 * vm_trace.c, vm.c, thread.c: get rid of (maybe false positive) warnings about
using uninitialized var with VC++.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 15:45:25 +00:00
akr
ce0c2b2170 test/test_syslog.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:59:24 +00:00
akr
1a956cea38 test/readline/test_readline.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46234 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:47:28 +00:00
nobu
fad56622f7 signal.c: return proper member
* signal.c (ruby_signal): should return either `old.sa_sigaction`
  or `old.sa_handler`, depending on whether `SA_SIGINFO` is set in
  `old.sa_flags`, because they may not be a union.
  [ruby-core:62836] [Bug #9878]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:27:53 +00:00
akr
52e91e0f72 * io.c (pipe_open): Close pipes when rb_execarg_fixup() raises
an exception.
  (rb_execarg_fixup_v): New function.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:13:20 +00:00
akr
6f39cf2d1e test/test_pty.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 13:38:39 +00:00
akr
b519ce9a8a * test/lib/minitest/unit.rb (capture_subprocess_io): Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 13:26:02 +00:00
akr
2edc9ea5f8 test/logger/test_logdevice.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 13:12:38 +00:00
akr
a2f9b00ad4 test/io/nonblock/test_flush.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 12:42:14 +00:00
akr
a1afdfeb06 test/fileutils/test_fileutils.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 12:07:39 +00:00
akr
be4d1fd953 * io.c (rb_io_s_pipe): Close pipes if io_encoding_set() raises an
exception.
  (io_encoding_set_v): New function.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 11:29:47 +00:00
akr
2ad2007307 * lib/csv.rb (CSV.open): Close the opened file when an exception occur.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 10:44:59 +00:00
akr
68ac33a511 * ext/openssl/lib/openssl/ssl.rb (SSLServer#accept): Close a socket
if any exception occur. 



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 10:32:19 +00:00
nobu
c65ef1539b configure.in: fix messages
* configure.in (RUBY_FUNC_ATTRIBUTE): show the attribute name in
  the message if the macro name is not given.  fix up r45608.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 00:58:21 +00:00
nobu
88789fdeed localeinit.c: revert r46202
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 23:35:43 +00:00
akr
4bf480b7d5 Suppress warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 22:59:07 +00:00
normal
205e690646 include/ruby/ruby.h: hide Symbol internals
This is too new to be a compatibility problem.

* include/ruby/ruby.h: Hide Symbol internals.
  (struct RSymbol): moved to internal.h
  (RSYMBOL): ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 20:08:56 +00:00
akr
eb9f446ebf * ext/socket/unixsocket.c (rsock_init_unixsock): Open a socket
after path length check.
  This fixes a fd leak by TestSocket_UNIXSocket#test_too_long_path.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 15:42:09 +00:00
svn
b73eaef7a8 * 2014-05-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 15:06:43 +00:00
akr
971df741b9 Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 15:06:39 +00:00
akr
a7b1cfbb99 * test/ruby/test_io.rb (test_flush_in_finalizer1): Use
ObjectSpace.each_object to close files.
  GC.start is not reliable.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 14:06:28 +00:00
akr
58a6412754 No need to kill a thread.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 11:17:48 +00:00
akr
cbd370f669 * lib/net/imap.rb (Net::IMAP#initialize): Close the opened socket when
any exception occur.
  This fixes a fd leak by IMAPTest#test_imaps_post_connection_check
  which start_tls_session() raises an exception.




git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 10:02:54 +00:00
akr
02afafb42a * ext/openssl/ossl_ssl.c (ossl_ssl_close): Fix sync_close to work
when SSL is not started.
  This fix the fd leak by test_https_proxy_authentication in
  test/net/http/test_https_proxy.rb.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 09:09:26 +00:00
nobu
73cf9abd1c drbtest.rb: avoid leaking threads
* test/drb/drbtest.rb (test_06_timeout): clean up worker threads
  to avoid leaking threads.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 08:03:55 +00:00
nobu
ca2c5ded93 test/rake: avoid leaking threads
* test/rake/test_rake_task.rb (teardown): clean up thread pool to
  avoid leaking threads.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 06:22:09 +00:00
nobu
15da4792de test/rake: avoid leaking threads
* test/rake/test_rake_multi_task.rb (teardown): clean up thread
  pool to avoid leaking threads.

* test/rake/test_rake_task_with_arguments.rb (teardown): ditto.

* test/rake/test_rake_thread_pool.rb: ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 06:05:43 +00:00
nobu
ea9e8fedb3 eval_intern.h: suppress warning by gcc 4.6
* eval_intern.h (VAR_FROM_MEMORY, VAR_INITIALIZED): gcc 4.6 also
  seems to warn false maybe-uninitialized.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 05:39:45 +00:00
nobu
391cad0cb3 test_socket.rb: ignore interface without address
* test/socket/test_socket.rb (test_udp_server): ignore interface
  with no address assigned.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 05:11:05 +00:00
zzak
e3adb1d647 [DOC] Typo in change log [ci skip]
Although a mint flavored test suite sounds delicious,
I believe it's supposed to be minitest!


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 04:34:22 +00:00
nobu
0a946cde01 localeinit.c: fallback filesystem encoding to UTF-8
* localeinit.c (Init_enc_set_filesystem_encoding): fallback to
  UTF-8 on Mac OS X, just for convenience sake.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 04:27:45 +00:00
nobu
d85195712d test_dir_m17n.rb: assert_raw_file_name
* test/ruby/test_dir_m17n.rb (assert_raw_file_name): rename to
  show caller method in failure messages.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 04:20:35 +00:00
nobu
bd50aaf618 envutil.rb: connect caller to backtrace
* test/ruby/envutil.rb (assert_separately): append current caller
  to backtrace show proper method name.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 04:20:31 +00:00
nobu
bd77dbc37a test_thread.rb: move thread switch test
* test/ruby/test_thread.rb (test_switch_while_busy_loop): move
  from test/test_timeout.rb.  [Bug #1402]

* test/test_timeout.rb (test_timeout): no longer related to
  [Bug #1402].  [Bug #8523]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 03:05:48 +00:00
normal
1142249713 vm.c: remove rb_vm_living_threads_foreach function
Shorter code with fewer callbacks and casts should be more readable.

* vm.c (rb_vm_living_threads_foreach): remove function
  [ruby-core:62745]
* thread.c (terminate_i): remove
* thread.c (terminate_all): implement (inlines old terminate_i)
* thread.c (rb_thread_terminate_all): use terminate_all
* thread.c (rb_thread_fd_close_i): remove
* thread.c (rb_thread_fd_close): iterate inline
* thread.c (thread_list_i): remove
* thread.c (rb_thread_list): iterate inline
* thread.c (rb_thread_atfork_internal): iterate inline
* thread.c (terminate_atfork_i): update types to remove casts
* thread.c (terminate_atfork_before_exec_i): ditto
* thread.c (struct thgroup_list_params): remove definition
* thread.c (thgroup_list_i): remove
* thread.c (thgroup_list): iterate inline
* thread.c (check_deadlock_i): remove
* thread.c (debug_deadlock_check): implement (inlines check_deadlock_i)
* thread.c (debug_i): remove
* thread.c (rb_check_deadlock): iterate inline
* vm.c (vm_mark_each_thread_func): remove
* vm.c (rb_vm_mark): iterate inline
* vm_core.h (rb_vm_living_threads_remove): remove
* vm_trace.c (clear_trace_func_i): remove
* vm_trace.c (rb_clear_trace_func): iterate inline

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 01:48:11 +00:00
normal
e303785dde signal: remove window for SignalException on IGNORE
* signal.c (signal_exec): ignore immediate cmd for SIG_IGN
* signal.c (trap_handler): set cmd to true for SIG_IGN
* signal.c (trap): handle nil and true values for oldcmd
  [Bug #9835]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 00:53:11 +00:00
akr
9e9fcfeef4 Use Tempfile#close!.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 16:17:13 +00:00
akr
592c6ba3b3 * lib/tempfile.rb (Tempfile#inspect): Show "(closed)" if the tempfile
is closed.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 16:03:35 +00:00
akr
9b612d382d * test/lib/minitest/unit.rb: Use Tempfile#close! instead of
Tempfile#unlink to close file descriptors.

* test/openssl/test_config.rb: Ditto.

* test/ruby/test_io.rb: Ditto.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 15:49:13 +00:00
akr
36276b6f40 Avoid a shadowing warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 15:15:54 +00:00
svn
dc4fa2f229 * 2014-05-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 15:15:14 +00:00
akr
569ca78e97 * lib/net/ftp.rb (transfercmd): Close TCP server socket even if an
exception occur.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 15:14:59 +00:00
akr
c968f908e1 * lib/cgi/core.rb: Use Tempfile#close(true) instead of Tempfile#unlink
to close file descriptors.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-27 14:51:08 +00:00