mirror of
https://github.com/ruby/ruby.git
synced 2025-09-15 16:44:01 +02:00
f4c16c57aa
In mock testing for stdout, `StringIO.new` is sometimes used to redirect the output.
In such cases, the assignment is done with `$stdout = StringIO.new`, not the constant `STDOUT`.
e.g., https://github.com/rubocop/rubocop/blob/v1.71.1/lib/rubocop/rspec/shared_contexts.rb#L154-L164
After assigning `StringIO.new`, `$stdout.tty?` returns `false`,
allowing the standard output destination to be switched during test execution.
```ruby
STDOUT.tty? # => true
StringIO.new.tty? # => false
```
However, since `STDOUT.tty?` returns `true`, a failure occurred in environments
where the environment variables `RUBY_PAGER` or `PAGER` are set.
e.g., https://github.com/rubocop/rubocop/pull/13784
To address this, `STDOUT` has been updated to `$stdout` so that the result of `tty?` can be flexibly overridden.
A potential concern is that `$stdout`, unlike `STDOUT`,
does not always represent the standard output at the time the Ruby process started.
However, no concrete examples of issues related to this have been identified.
`STDOUT.tty?` is the logic of optparse introduced in https://github.com/ruby/optparse/pull/70.
This PR replaces `STDOUT` with `$stdout` throughout, based on the assumption
that `$stdout` is sufficient for use with optparse.
|
||
|---|---|---|
| .. | ||
| test_acceptable.rb | ||
| test_autoconf.rb | ||
| test_bash_completion.rb | ||
| test_cclass.rb | ||
| test_did_you_mean.rb | ||
| test_getopts.rb | ||
| test_kwargs.rb | ||
| test_load.rb | ||
| test_noarg.rb | ||
| test_optarg.rb | ||
| test_optparse.rb | ||
| test_placearg.rb | ||
| test_reqarg.rb | ||
| test_summary.rb | ||
| test_zsh_completion.rb | ||